Add win32 gtest filter files shared between Wine and TSan/Windows

Add win32 gtest filter files shared between Wine and TSan/Windows
BUG=28363
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43076

[Timur Iskhodzhanov, 2010-03-26 16:31:51]

Hi Lei,

Currently I'm working on enabling ThreadSanitizer for Windows.

As I've noticed, you have already disabled most of the windows problematic tests
for your wine_memcheck bot.
I'd like to introduce _win32 gtest files which will be used on wine bots along
with _wine files so we re-use each other's work instead of duplicating.

Can you please review the CL?

Thank you,
Timur

http://codereview.chromium.org/1377003/diff/4001/5003
File base/data/valgrind/base_unittests.gtest_wine.txt (left):

http://codereview.chromium.org/1377003/diff/4001/5003#oldcode23
base/data/valgrind/base_unittests.gtest_wine.txt:23: DirectoryWatcherTest.*
These tests have been removed

http://codereview.chromium.org/1377003/diff/4001/5003#oldcode98
base/data/valgrind/base_unittests.gtest_wine.txt:98: # flaky-valgrind
moved to win32 file

http://codereview.chromium.org/1377003/diff/4001/5001
File tools/valgrind/common.py (right):

http://codereview.chromium.org/1377003/diff/4001/5001#newcode152
tools/valgrind/common.py:152: return ['wine', 'win32']
the idea is that the set of wine-compatible tests is a subset of tests that run
fine under 'generalized' tool on Win32.

[Lei Zhang, 2010-03-26 22:55:49]

LGTM

It feels a bit odd for a platform to have multiple names, but splitting
PlatformNames() into PlatformName() and SecondaryPlatformNames() just makes for
more typing.

On 2010/03/26 16:31:51, Timur Iskhodzhanov wrote:
> Hi Lei,
> 
> Currently I'm working on enabling ThreadSanitizer for Windows.
> 
> As I've noticed, you have already disabled most of the windows problematic
tests
> for your wine_memcheck bot.
> I'd like to introduce _win32 gtest files which will be used on wine bots along
> with _wine files so we re-use each other's work instead of duplicating.
> 
> Can you please review the CL?
> 
> Thank you,
> Timur
> 
> http://codereview.chromium.org/1377003/diff/4001/5003
> File base/data/valgrind/base_unittests.gtest_wine.txt (left):
> 
> http://codereview.chromium.org/1377003/diff/4001/5003#oldcode23
> base/data/valgrind/base_unittests.gtest_wine.txt:23: DirectoryWatcherTest.*
> These tests have been removed
> 
> http://codereview.chromium.org/1377003/diff/4001/5003#oldcode98
> base/data/valgrind/base_unittests.gtest_wine.txt:98: # flaky-valgrind
> moved to win32 file
> 
> http://codereview.chromium.org/1377003/diff/4001/5001
> File tools/valgrind/common.py (right):
> 
> http://codereview.chromium.org/1377003/diff/4001/5001#newcode152
> tools/valgrind/common.py:152: return ['wine', 'win32']
> the idea is that the set of wine-compatible tests is a subset of tests that
run
> fine under 'generalized' tool on Win32.

[Alexander Potapenko, 2010-04-02 10:01:20]

LGTM
On 2010/03/26 22:55:49, Lei Zhang wrote:
> LGTM
> 
> It feels a bit odd for a platform to have multiple names, but splitting
> PlatformNames() into PlatformName() and SecondaryPlatformNames() just makes
for
> more typing.
> 
> On 2010/03/26 16:31:51, Timur Iskhodzhanov wrote:
> > Hi Lei,
> > 
> > Currently I'm working on enabling ThreadSanitizer for Windows.
> > 
> > As I've noticed, you have already disabled most of the windows problematic
> tests
> > for your wine_memcheck bot.
> > I'd like to introduce _win32 gtest files which will be used on wine bots
along
> > with _wine files so we re-use each other's work instead of duplicating.
> > 
> > Can you please review the CL?
> > 
> > Thank you,
> > Timur
> > 
> > http://codereview.chromium.org/1377003/diff/4001/5003
> > File base/data/valgrind/base_unittests.gtest_wine.txt (left):
> > 
> > http://codereview.chromium.org/1377003/diff/4001/5003#oldcode23
> > base/data/valgrind/base_unittests.gtest_wine.txt:23: DirectoryWatcherTest.*
> > These tests have been removed
> > 
> > http://codereview.chromium.org/1377003/diff/4001/5003#oldcode98
> > base/data/valgrind/base_unittests.gtest_wine.txt:98: # flaky-valgrind
> > moved to win32 file
> > 
> > http://codereview.chromium.org/1377003/diff/4001/5001
> > File tools/valgrind/common.py (right):
> > 
> > http://codereview.chromium.org/1377003/diff/4001/5001#newcode152
> > tools/valgrind/common.py:152: return ['wine', 'win32']
> > the idea is that the set of wine-compatible tests is a subset of tests that
> run
> > fine under 'generalized' tool on Win32.