Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 1377003: Add win32 gtest filter files shared between Wine and TSan/Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/valgrind/common.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
===================================================================
--- tools/valgrind/valgrind_test.py (revision 43070)
+++ tools/valgrind/valgrind_test.py (working copy)
@@ -479,8 +479,8 @@
ret = []
ignore_files = ["ignores.txt"]
- platform_suffix = common.PlatformName()
- ignore_files.append("ignores_%s.txt" % platform_suffix)
+ for platform_suffix in common.PlatformNames():
+ ignore_files.append("ignores_%s.txt" % platform_suffix)
for ignore_file in ignore_files:
fullname = os.path.join(self._source_dir,
"tools", "valgrind", "tsan", ignore_file)
@@ -537,13 +537,11 @@
if tool_name == "wine_memcheck" and common.IsWine():
return Memcheck()
if tool_name == "tsan":
- if not common.IsLinux():
- logging.info("WARNING: ThreadSanitizer may be unstable on Mac.")
- logging.info("See http://code.google.com/p/data-race-test/wiki/"
- "ThreadSanitizerOnMacOsx for the details")
+ if common.IsWindows():
+ logging.info("WARNING: ThreadSanitizer Windows support is experimental.")
return ThreadSanitizer()
try:
- platform_name = common.PlatformName()
+ platform_name = common.PlatformNames()[0]
except common.NotImplementedError:
platform_name = sys.platform + "(Unknown)"
raise RuntimeError, "Unknown tool (tool=%s, platform=%s)" % (tool_name,
« no previous file with comments | « tools/valgrind/common.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698