Issue 1371006: Add more tests to desktopui_IBusTest

Issue 1371006: Add more tests to desktopui_IBusTest (Closed)

Created:
10 years, 9 months ago by satorux1

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato

CC:
chromium-os-reviews_chromium.org, kmixter1, petkov, seano, ericli, sosa, mazda

Visibility:
Public.

Description

Add more tests to desktopui_IBusTest - Add test_supported_engines() that checks if supported engines exist - Add test_reachable() that checks if ibus-daemon is reachable (we already had this, but make it nicer)

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : minor fix #

Total comments: 4

Patch Set 4 : merge and address comments #

Patch Set 5 : add time back #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -8 lines)			Patch
	M	client/deps/ibusclient/src/ibusclient.cc	View	1	1 chunk	+40 lines, -3 lines	0 comments	Download
	M	client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py	View	2 3 4	3 chunks	+28 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

http://codereview.chromium.org/1371006/diff/6001/7002 File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right): http://codereview.chromium.org/1371006/diff/6001/7002#newcode33 client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:33: expected_engine_names = ['hangul', 'pinyin', 'm17n:ar:kbd'] please add chewing. http://codereview.chromium.org/1371006/diff/6001/7002#newcode36 ...

10 years, 9 months ago (2010-03-26 09:04:12 UTC) #2

satorux1

Thanks! http://codereview.chromium.org/1371006/diff/6001/7002 File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right): http://codereview.chromium.org/1371006/diff/6001/7002#newcode33 client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:33: expected_engine_names = ['hangul', 'pinyin', 'm17n:ar:kbd'] On 2010/03/26 09:04:23, ...

10 years, 9 months ago (2010-03-26 09:08:38 UTC) #3

Yusuke Sato

10 years, 9 months ago (2010-03-26 09:10:36 UTC) #4

LGTM

On 2010/03/26 09:08:38, satorux1 wrote:
> Thanks!
> 
> http://codereview.chromium.org/1371006/diff/6001/7002
> File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right):
> 
> http://codereview.chromium.org/1371006/diff/6001/7002#newcode33
> client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:33:
> expected_engine_names = ['hangul', 'pinyin', 'm17n:ar:kbd']
> On 2010/03/26 09:04:23, Yusuke Sato wrote:
> > please add chewing.
> 
> Done.
> 
> http://codereview.chromium.org/1371006/diff/6001/7002#newcode36
> client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:36: raise
> error.TestFail('Engine not foundd: ' +
> On 2010/03/26 09:04:23, Yusuke Sato wrote:
> > foundd -> found
> 
> Done.

Expand Messages | Collapse Messages