Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py

Issue 1371006: Add more tests to desktopui_IBusTest (Closed)
Patch Set: add time back Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/deps/ibusclient/src/ibusclient.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
diff --git a/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py b/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
index cfb47c63845d45f00a1c2a366aa58d212f5b9c36..3f68b3eaf5f842bf3219eb6fe5cdc396cbea6f6f 100644
--- a/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
+++ b/client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py
@@ -2,9 +2,9 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import logging, os, time, utils
+import logging, os, time
from autotest_lib.client.bin import site_login, test
-from autotest_lib.client.common_lib import error, site_ui
+from autotest_lib.client.common_lib import error, site_ui, utils
def wait_for_ibus_daemon_or_die(timeout=10):
# Wait until ibus-daemon starts. ibus-daemon starts after a user
@@ -27,6 +27,28 @@ class desktopui_IBusTest(test.test):
self.job.setup_dep(['ibusclient'])
+ def run_ibusclient(self, options):
+ cmd = site_ui.xcommand_as('%s %s' % (self.exefile, options), 'chronos')
+ return utils.system_output(cmd, retain_output=True)
+
+
+ def test_reachable(self):
+ out = self.run_ibusclient('check_reachable')
+ if not 'YES' in out:
+ raise error.TestFail('ibus-daemon is not reachable')
+
+
+ def test_supported_engines(self):
+ out = self.run_ibusclient('list_engines')
+ engine_names = out.splitlines()
+ # We expect these engines to exist.
+ expected_engine_names = ['chewing', 'hangul', 'pinyin', 'm17n:ar:kbd']
+ for expected_engine_name in expected_engine_names:
+ if not expected_engine_name in engine_names:
+ raise error.TestFail('Engine not found: ' +
+ expected_engine_name)
+
+
def run_once(self):
logged_in = site_login.logged_in()
if not logged_in:
@@ -38,9 +60,10 @@ class desktopui_IBusTest(test.test):
dep_dir = os.path.join(self.autodir, 'deps', dep)
self.job.install_pkg(dep, 'dep', dep_dir)
- exefile = os.path.join(self.autodir, 'deps/ibusclient/ibusclient')
- cmd = site_ui.xcommand_as(exefile, 'chronos')
- utils.system_output(cmd, retain_output=True)
+ self.exefile = os.path.join(self.autodir,
+ 'deps/ibusclient/ibusclient')
+ self.test_reachable()
+ self.test_supported_engines()
finally:
# If we started logged out, log back out.
if not logged_in:
« no previous file with comments | « client/deps/ibusclient/src/ibusclient.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698