Scope the WriteTransactions during model association so that we don't lock the UI thread

Scope the WriteTransactions during model association so that we don't lock the UI thread

BUG=34206
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42708

[tim (not reviewing), 2010-03-25 23:37:19]

LGTM with a few comments

http://codereview.chromium.org/1361002/diff/1/2
File chrome/browser/sync/glue/autofill_model_associator.cc (right):

http://codereview.chromium.org/1361002/diff/1/2#newcode131
chrome/browser/sync/glue/autofill_model_associator.cc:131: sync_child_id =
sync_child_node.GetSuccessorId();
holy mangled diff for tiny change, batman!

http://codereview.chromium.org/1361002/diff/1/2#newcode134
chrome/browser/sync/glue/autofill_model_associator.cc:134: 
maybe add a comment here since this is subtle: the syncer thread is paused
during model association, so the Syncer is not writing to the sync DB, and since
we're on the DB thread nothing can be written to the autofill db before us,
either.

http://codereview.chromium.org/1361002/diff/1/3
File chrome/browser/sync/glue/typed_url_change_processor.cc (right):

http://codereview.chromium.org/1361002/diff/1/3#newcode65
chrome/browser/sync/glue/typed_url_change_processor.cc:65: // TODO(sync): Get
visists without holding the write transaction.
ubernit- visits, and please reference the bug#.

http://codereview.chromium.org/1361002/diff/1/4
File chrome/browser/sync/glue/typed_url_model_associator.cc (right):

http://codereview.chromium.org/1361002/diff/1/4#newcode134
chrome/browser/sync/glue/typed_url_model_associator.cc:134: 
similar comment to the autofill one here would be handy.

[Zachary Kuznia, 2010-03-25 23:51:04]

http://codereview.chromium.org/1361002/diff/1/2
File chrome/browser/sync/glue/autofill_model_associator.cc (right):

http://codereview.chromium.org/1361002/diff/1/2#newcode134
chrome/browser/sync/glue/autofill_model_associator.cc:134: 
On 2010/03/25 23:37:19, timsteele wrote:
> maybe add a comment here since this is subtle: the syncer thread is paused
> during model association, so the Syncer is not writing to the sync DB, and
since
> we're on the DB thread nothing can be written to the autofill db before us,
> either.

Done.

http://codereview.chromium.org/1361002/diff/1/3
File chrome/browser/sync/glue/typed_url_change_processor.cc (right):

http://codereview.chromium.org/1361002/diff/1/3#newcode65
chrome/browser/sync/glue/typed_url_change_processor.cc:65: // TODO(sync): Get
visists without holding the write transaction.
On 2010/03/25 23:37:19, timsteele wrote:
> ubernit- visits, and please reference the bug#.

Done.

http://codereview.chromium.org/1361002/diff/1/4
File chrome/browser/sync/glue/typed_url_model_associator.cc (right):

http://codereview.chromium.org/1361002/diff/1/4#newcode134
chrome/browser/sync/glue/typed_url_model_associator.cc:134: 
On 2010/03/25 23:37:19, timsteele wrote:
> similar comment to the autofill one here would be handy.

Done.