Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chrome/browser/sync/glue/typed_url_change_processor.cc

Issue 1361002: Scope the WriteTransactions during model association so that we don't lock the UI thread (Closed)
Patch Set: Added comments, fixed a typo Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/typed_url_change_processor.cc
diff --git a/chrome/browser/sync/glue/typed_url_change_processor.cc b/chrome/browser/sync/glue/typed_url_change_processor.cc
index 709c5e6803bc1f4c4f4d529930cc389db3221e73..4701b3aa2370c2c2cbc7eb8ef8f78451a868729b 100644
--- a/chrome/browser/sync/glue/typed_url_change_processor.cc
+++ b/chrome/browser/sync/glue/typed_url_change_processor.cc
@@ -62,6 +62,9 @@ void TypedUrlChangeProcessor::HandleURLsModified(
history::URLsModifiedDetails* details) {
sync_api::WriteTransaction trans(share_handle());
+ // TODO(sync): Get visits without holding the write transaction.
+ // See issue 34206
+
sync_api::ReadNode typed_url_root(&trans);
if (!typed_url_root.InitByTagLookup(kTypedUrlTag)) {
error_handler()->OnUnrecoverableError();
« no previous file with comments | « chrome/browser/sync/glue/autofill_model_associator.cc ('k') | chrome/browser/sync/glue/typed_url_model_associator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698