Issue 1356002: Add kochi and dejavu fonts to default package list on linux

Issue 1356002: Add kochi and dejavu fonts to default package list on linux (Closed)

Created:
10 years, 9 months ago by jamesr

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Add kochi and dejavu fonts to default package list on linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42704

Patch Set 2 : Fix line wrapping of comment #

Total comments: 2

Patch Set 3 : I can haz sort #

Patch Set 4 : Fix #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	build/install-build-deps.sh	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/test_shell/test_shell_gtk.cc	View	1 2	3 chunks	+6 lines, -5 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

be sure to update http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites#Ubuntu_Setup http://codereview.chromium.org/1356002/diff/2001/3002 File webkit/tools/test_shell/test_shell_gtk.cc (right): http://codereview.chromium.org/1356002/diff/2001/3002#newcode247 webkit/tools/test_shell/test_shell_gtk.cc:247: "/usr/share/fonts/truetype/kochi/kochi-mincho.ttf", This list appears ...

10 years, 9 months ago (2010-03-25 23:02:53 UTC) #2

jamesr

Correctly sorted this time. I've also updated the wiki page LinuxBuildInstructions so that its apt-get ...

10 years, 9 months ago (2010-03-25 23:22:01 UTC) #3

Evan Martin

10 years, 9 months ago (2010-03-25 23:26:12 UTC) #4

LGTM

http://codereview.chromium.org/1356002/diff/10001/11002
File webkit/tools/test_shell/test_shell_gtk.cc (right):

http://codereview.chromium.org/1356002/diff/10001/11002#newcode271
webkit/tools/test_shell/test_shell_gtk.cc:271: << "This will also install a
JRE";
Ok, this JRE comment is a bit weird.  (Why mention it?  Is it required by the
build?  Etc.  Even an emoticon would make it clearer I think)

Expand Messages | Collapse Messages