Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: webkit/tools/test_shell/test_shell_gtk.cc

Issue 1356002: Add kochi and dejavu fonts to default package list on linux (Closed)
Patch Set: Fix Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/install-build-deps.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_gtk.cc
diff --git a/webkit/tools/test_shell/test_shell_gtk.cc b/webkit/tools/test_shell/test_shell_gtk.cc
index bce9c31577951981615f24f6fd7af89d3f0a09c1..61a895ab08941360ad8a8f2cf476013b53dd166c 100644
--- a/webkit/tools/test_shell/test_shell_gtk.cc
+++ b/webkit/tools/test_shell/test_shell_gtk.cc
@@ -211,6 +211,8 @@ void TestShell::InitializeTestShell(bool layout_test_mode) {
// will try its best to match based only on the fonts here in. The
// paths are where these fonts are found on our Ubuntu boxes.
static const char *const fonts[] = {
+ "/usr/share/fonts/truetype/kochi/kochi-gothic.ttf",
+ "/usr/share/fonts/truetype/kochi/kochi-mincho.ttf",
"/usr/share/fonts/truetype/msttcorefonts/Arial.ttf",
"/usr/share/fonts/truetype/msttcorefonts/Arial_Bold.ttf",
"/usr/share/fonts/truetype/msttcorefonts/Arial_Bold_Italic.ttf",
@@ -238,6 +240,8 @@ void TestShell::InitializeTestShell(bool layout_test_mode) {
"/usr/share/fonts/truetype/msttcorefonts/Verdana_Bold.ttf",
"/usr/share/fonts/truetype/msttcorefonts/Verdana_Bold_Italic.ttf",
"/usr/share/fonts/truetype/msttcorefonts/Verdana_Italic.ttf",
+ // The DejaVuSans font is used by the LayoutTests/css2.1 tests
+ "/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf",
"/usr/share/fonts/truetype/ttf-indic-fonts-core/lohit_ta.ttf",
"/usr/share/fonts/truetype/ttf-indic-fonts-core/lohit_pa.ttf",
"/usr/share/fonts/truetype/ttf-indic-fonts-core/MuktiNarrow.ttf",
@@ -257,17 +261,14 @@ void TestShell::InitializeTestShell(bool layout_test_mode) {
// few layout tests.
static const char* const optional_fonts[] = {
"/usr/share/fonts/truetype/ttf-lucida/LucidaSansRegular.ttf",
- "/usr/share/fonts/truetype/kochi/kochi-gothic.ttf",
- "/usr/share/fonts/truetype/kochi/kochi-mincho.ttf",
- "/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf",
};
for (size_t i = 0; i < arraysize(optional_fonts); ++i) {
const char* font = optional_fonts[i];
if (access(font, R_OK) < 0) {
LOG(WARNING) << "You are missing " << font << ". "
<< "Without this, some layout tests will fail. "
- << "It's not a major problem. See the build instructions "
- << "for more information on where to get all the data.";
+ << "To get LucidaSansRegular, install sun-java6-fonts. "
+ << "This will also install a JRE";
Evan Martin 2010/03/25 23:26:12 Ok, this JRE comment is a bit weird. (Why mention
} else {
if (!FcConfigAppFontAddFile(fontcfg, (FcChar8 *) font))
LOG(FATAL) << "Failed to load font " << font;
« no previous file with comments | « build/install-build-deps.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698