Issue 1353003: GTK: Provide GTK+ themed notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1353003: GTK: Provide GTK+ themed notifications. (Closed)

Created:
10 years, 9 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org, Elliot Glaysher

Visibility:
Public.

Description

GTK: Provide GTK+ themed notifications. BUG=34514 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42705

Patch Set 3 : Redraw on change #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -19 lines)			Patch
	M	chrome/browser/gtk/notifications/balloon_view_gtk.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/notifications/balloon_view_gtk.cc	View	1 2	7 chunks	+59 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

screenshot? http://codereview.chromium.org/1353003/diff/2001/3001 File chrome/browser/gtk/notifications/balloon_view_gtk.cc (right): http://codereview.chromium.org/1353003/diff/2001/3001#newcode360 chrome/browser/gtk/notifications/balloon_view_gtk.cc:360: gtk_chrome_button_set_use_gtk_rendering( isn't this handled by the theme provider

10 years, 9 months ago (2010-03-25 23:29:03 UTC) #2

Elliot Glaysher

On Thu, Mar 25, 2010 at 4:29 PM, <estade@chromium.org> wrote: > screenshot? Attached. > http://codereview.chromium.org/1353003/diff/2001/3001 ...

10 years, 9 months ago (2010-03-25 23:39:06 UTC) #3

lgtm

Expand Messages | Collapse Messages

Issue 1353003: GTK: Provide GTK+ themed notifications. (Closed)

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : Redraw on change #

Messages