Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1345005: Mac: Initial Geolocation UI. (Closed)

Created:
10 years, 9 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
joth, viettrungluu
CC:
chromium-reviews
Visibility:
Public.

Description

Mac: Initial Geolocation UI. For now, an in-progress version of the bubble/omnibox icon. The bubble shows up, but doesn't do much yet. The two buttons are disabled because they both don't do anything yet. Since this is behind a flag, I think checking in work-in-progress UI is fine. Parts of this CL were merged in from http://codereview.chromium.org/1369002 . Ignore the files from that CL. http://imgur.com/tWJhg BUG=11246 TEST=Start chrome with --enable-geolocation, go to http://maxheapsize.com/static/html5geolocationdemo.html , click allow or deny, observe that an icon appears. Click icon, a bubble appears. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42756

Patch Set 1 #

Patch Set 2 : disable buttons #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+757 lines, -3 lines) Patch
A chrome/app/nibs/ContentBubbleGeolocation.xib View 1 1 chunk +754 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/content_blocked_bubble_controller.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Note that most of the files are from a merged CL. There's a two-line change ...
10 years, 9 months ago (2010-03-26 05:02:45 UTC) #1
viettrungluu
You're not lying! (But I blame you anyway.) LGTM.
10 years, 9 months ago (2010-03-26 06:08:12 UTC) #2
viettrungluu
You've really got to %s/googlegroups\.com/chromium.org/g in your .git/config though.
10 years, 9 months ago (2010-03-26 06:12:53 UTC) #3
joth
LGTM. Just one question -- is the "Not done yet" label in the screen shot ...
10 years, 9 months ago (2010-03-26 14:04:23 UTC) #4
Nico
10 years, 9 months ago (2010-03-26 14:11:32 UTC) #5
Thanks, guys.

The "Not done yet" is just a disclaimer. I'll remove it soon.

Powered by Google App Engine
This is Rietveld 408576698