Issue 1344003: Revert 42656 - Add a Pepper audio basic functionality unit test....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1344003: Revert 42656 - Add a Pepper audio basic functionality unit test.... (Closed)

Created:
10 years, 9 months ago by Sam Kerner (Chrome)

Modified:
9 years, 7 months ago

Reviewers:
neb

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 42656 - Add a Pepper audio basic functionality unit test. Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters. Review URL: http://codereview.chromium.org/1207005 TBR=neb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42692

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -55 lines)			Patch
M	chrome/browser/renderer_host/mock_render_process_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/ipc_test_sink.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/common/ipc_test_sink.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/mock_render_thread.cc	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	chrome/renderer/pepper_devices_unittest.cc	View	3 chunks	+0 lines, -27 lines	0 comments	Download
M	ipc/ipc_channel.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sam Kerner (Chrome)

This change caused some valgrind failures that look dangerous. Please fix them if they are ...

10 years, 9 months ago (2010-03-25 23:24:33 UTC) #2

neb at google

10 years, 9 months ago (2010-03-25 23:25:35 UTC) #4

Ok, we can just revert this until I have the time to look into it.

On Thu, Mar 25, 2010 at 4:24 PM, <skerner@chromium.org> wrote:

> This change caused some valgrind failures that look dangerous.  Please fix
> them
> if they are real, and suppress them if they are spurious.
>
> Sam
>
>
> http://codereview.chromium.org/1344003
>

Expand Messages | Collapse Messages