Add test for power_menu_button.

Add test for power_menu_button.
BUG=none
TEST=power_menu_button_browsertest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42695

[Charlie Lee, 2010-03-25 20:55:06]

The mock cros library works great!

[zel, 2010-03-25 21:11:11]

http://codereview.chromium.org/1338003/diff/1/4
File chrome/browser/chromeos/status/power_menu_button_browsertest.cc (right):

http://codereview.chromium.org/1338003/diff/1/4#newcode70
chrome/browser/chromeos/status/power_menu_button_browsertest.cc:70:
EXPECT_EQ(id, CallPowerChangedAndGetIconId());
This might not actually work the way you expect it. gMock will check all
conditions when you exit your test function, not when you exit for{} block. I
will ping you with a sample how what you want can be done.

[Charlie Lee, 2010-03-25 21:22:52]

Hmm, it seems to work as I expect it to. When I change this line:
    EXPECT_EQ(id, CallPowerChangedAndGetIconId());
To:
    EXPECT_EQ(id+1, CallPowerChangedAndGetIconId());

I get 12 failures, each complaining that the value is one less than
expected.

- Charlie


On Thu, Mar 25, 2010 at 2:11 PM, <zelidrag@chromium.org> wrote:

>
> http://codereview.chromium.org/1338003/diff/1/4
> File chrome/browser/chromeos/status/power_menu_button_browsertest.cc
> (right):
>
> http://codereview.chromium.org/1338003/diff/1/4#newcode70
> chrome/browser/chromeos/status/power_menu_button_browsertest.cc:70:
> EXPECT_EQ(id, CallPowerChangedAndGetIconId());
> This might not actually work the way you expect it. gMock will check all
> conditions when you exit your test function, not when you exit for{}
> block. I will ping you with a sample how what you want can be done.
>
>
> http://codereview.chromium.org/1338003
>

[zel, 2010-03-25 23:26:22]

LGTM