Issue 1334002: Add the linux_use_heapchecker GYP variable that should turn the tcmalloc heap...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1334002: Add the linux_use_heapchecker GYP variable that should turn the tcmalloc heap... (Closed)

Created:
10 years, 9 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
Mike Belshe, willchan no longer on Chromium

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add the linux_use_heapchecker GYP variable that should turn the tcmalloc heap lleak checker on and off. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42740

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -3 lines)			Patch
M	base/allocator/allocator.gyp	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	base/leak_annotations.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/build_config.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	build/common.gypi	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

LGTM On 2010/03/25 15:55:45, Alexander Potapenko wrote: > Folks, > > Would you mind taking ...

10 years, 9 months ago (2010-03-25 16:25:09 UTC) #2

willchan no longer on Chromium

10 years, 9 months ago (2010-03-25 16:29:01 UTC) #3

lgtm2

On Thu, Mar 25, 2010 at 9:25 AM,  <mbelshe@chromium.org> wrote:
> LGTM
>
> On 2010/03/25 15:55:45, Alexander Potapenko wrote:
>>
>> Folks,
>
>> Would you mind taking a look?
>
>
>
> http://codereview.chromium.org/1334002
>

Expand Messages | Collapse Messages