Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1332001: Switch from he.xtb to iw.xtb because the translation console is (Closed)

Created:
10 years, 9 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Switch from he.xtb to iw.xtb because the translation console is deprecating 'he' in favor of 'iw'. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42713

Patch Set 1 #

Patch Set 2 : use he #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M app/resources/app_strings.grd View 1 1 chunk +2 lines, -1 line 0 comments Download
A + app/resources/app_strings_iw.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/app/resources/generated_resources_iw.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/app/resources/google_chrome_strings_iw.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/grit/node/io.py View 1 chunk +4 lines, -1 line 1 comment Download
A + webkit/glue/resources/webkit_strings_iw.xtb View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webkit_strings.grd View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
Chromium side changes for switching from he.xtb to iw.xtb. The perforce side change is one ...
10 years, 9 months ago (2010-03-25 09:30:47 UTC) #1
tony
adding jungshik
10 years, 9 months ago (2010-03-25 23:53:37 UTC) #2
Mark Larson (Google)
LGTM. There are other .grd files that we've never translated so far. chrome/trunk/src/chrome/app/chromium_strings.grd chrome/trunk/src/webkit/glue/devtools_strings.grd chrome/trunk/src/webkit/glue/inspector_strings.grd ...
10 years, 9 months ago (2010-03-26 00:32:42 UTC) #3
tony
10 years, 9 months ago (2010-03-26 01:09:21 UTC) #4
On 2010/03/26 00:32:42, Mark Larson (Google) wrote:
> LGTM. 
> 
> There are other .grd files that we've never translated so far. 
> 
> chrome/trunk/src/chrome/app/chromium_strings.grd
> chrome/trunk/src/webkit/glue/devtools_strings.grd
> chrome/trunk/src/webkit/glue/inspector_strings.grd
> 
> Shouldn't hold up this CL, but it would be good to update those so that if we
> ever _do_ try to translate them, the failure to generate he.dll isn't a
mystery.

These files currently don't have xtb files checked in, so there's nothing to
update in them.

> http://codereview.chromium.org/1332001/diff/3001/4007
> File tools/grit/grit/node/io.py (right):
> 
> http://codereview.chromium.org/1332001/diff/3001/4007#newcode54
> tools/grit/grit/node/io.py:54: (lang == 'iw' and self.attrs['lang'] == 'he')),
> ('The XTB file you '
> We don't do this for lang=='nb'. Should we?

That's a good question.  Unfortunately, our handling of no/nb is different from
our handling of he/iw.

for no/nb:
translation console: no
within chrome code: no
locale dll: nb

for he/iw
translation console: iw
within chrome code: he
locale dll: he

Because of the difference here, we don't need to change the assert in grit.

Powered by Google App Engine
This is Rietveld 408576698