Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 13278: Context menu key should work on download page... (Closed)

Created:
12 years ago by Mohamed Mansour (USE mhm)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Context menu key should work on download page As well, added keyboard navigation to the items to make it slicker and better, such as tabs and arrows BUG=3679 (http://crbug.com/3679)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M chrome/browser/views/download_tab_view.h View 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/views/download_tab_view.cc View 7 chunks +51 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mohamed Mansour (USE mhm)
12 years ago (2008-12-09 01:49:06 UTC) #1
Peter Kasting
I changed the reviewer here to Glen because he's about to throw away this UI ...
12 years ago (2008-12-09 02:00:31 UTC) #2
Glen Murphy
> I changed the reviewer here to Glen because he's about to > throw away ...
12 years ago (2008-12-09 02:06:01 UTC) #3
Peter Kasting
On 2008/12/09 02:06:01, Glen Murphy wrote: > Yes, please assume that NativeUIs will be deprecated ...
12 years ago (2008-12-09 02:08:32 UTC) #4
Mohamed Mansour (USE mhm)
12 years ago (2008-12-09 02:35:55 UTC) #5
On 2008/12/09 02:06:01, Glen Murphy wrote:
> I will send an email to chromium-dev, sorry for letting your effort get spent
> like this.

Ah no worries. At least I learned a lot while fixing this. That what counts :)

Powered by Google App Engine
This is Rietveld 408576698