Context menu key should work on download page...

chrome/browser/views/download_tab_view.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/download_tab_view.h"
 
 #include <time.h>
 
 #include <algorithm>
 #include <functional>
@@ skipping 166 matching lines @@
 
   cancel_ = new views::Link(l10n_util::GetString(IDS_DOWNLOAD_LINK_CANCEL));
   cancel_->SetController(this);
   cancel_->SetFont(font);
   AddChildView(cancel_);
 
   show_ = new views::Link(l10n_util::GetString(IDS_DOWNLOAD_LINK_SHOW));
   show_->SetController(this);
   show_->SetFont(font);
   AddChildView(show_);
+
+  SetFocusable(true);
+
+  SetContextMenuController(this);
 }
 
 DownloadItemTabView::~DownloadItemTabView() {
 }
 
 void DownloadItemTabView::SetModel(DownloadItem* model,
                                    DownloadTabView* parent) {
   DCHECK(model && parent);
   model_ = model;
   parent_ = parent;
@@ skipping 485 matching lines @@
                         highlighted_bounds.width(),
                         highlighted_bounds.height());
 
     canvas->DrawFocusRect(highlighted_bounds.x(),
                           highlighted_bounds.y(),
                           highlighted_bounds.width(),
                           highlighted_bounds.height());
   }
 }
 
+bool DownloadItemTabView::CanProcessTabKeyEvents() {
+  return true;
+}
+
+bool DownloadItemTabView::OnKeyPressed(const views::KeyEvent& event) {
+  // When you press DOWN or TAB select the next item in the downloads, otherwise
+  // when you press SHIFT+TAB or UP select the previous item. Note that the
+  // first download index is always in reverse, hence last index.
+  if (event.GetCharacter() == VK_DOWN || (GetKeyState(VK_SHIFT) >= 0 &&
+                                          event.GetCharacter() == VK_TAB)) {
+    parent_->SelectItemAtIndex(parent_->selected_index() - 1);
+  }
+  else if (event.GetCharacter() == VK_UP || (GetKeyState(VK_SHIFT) < 0 &&
+                                             event.GetCharacter() == VK_TAB)) {
+    parent_->SelectItemAtIndex(parent_->selected_index() + 1);
+  }
+  return true;
+}
+
 bool DownloadItemTabView::OnMousePressed(const views::MouseEvent& event) {
   gfx::Point point(event.location());
 
   // If the click is in the highlight region, then highlight this download.
   // Otherwise, remove the highlighting from any download.
   gfx::Rect select_rect(
       kDownloadIconOffset - parent_->big_icon_offset(),
       0,
       kDownloadIconOffset - parent_->big_icon_offset() +
       parent_->big_icon_size() + kInfoPadding + kFilenameSize,
       parent_->big_icon_size());
 
   // The position of the highlighted region does not take into account the
   // View's UI layout so we have to manually mirror the position if the View is
   // using a right-to-left UI layout.
   gfx::Rect mirrored_rect(select_rect);
   select_rect.set_x(MirroredLeftPointForRect(mirrored_rect));
   if (select_rect.Contains(point)) {
+    // Request Focus if not present to allow keyboard events to work and context
+    // menu to function properly.
+    if (!HasFocus())
+      RequestFocus();
+
     parent_->ItemBecameSelected(model_);
 
     // Don't show the right-click menu if we are prompting the user for a
     // dangerous download.
     if (event.IsRightMouseButton() &&
         model_->safety_state() != DownloadItem::DANGEROUS) {
       views::View::ConvertPointToScreen(this, &point);
 
       download_util::DownloadDestinationContextMenu menu(
           model_, GetWidget()->GetHWND(), point.ToPOINT());
     }
   } else {
     parent_->ItemBecameSelected(NULL);
   }
 
   return true;
 }
 
 // Handle drag (file copy) operations.
 bool DownloadItemTabView::OnMouseDragged(const views::MouseEvent& event) {
   if (model_->state() != DownloadItem::COMPLETE ||
       model_->safety_state() == DownloadItem::DANGEROUS)
     return false;
 
-  CPoint point(event.x(), event.y());
+  gfx::Point point(event.x(), event.y());
 
   // In order to make sure drag and drop works as expected when the UI is
   // mirrored, we can either flip the mouse X coordinate or flip the X position
   // of the drag rectangle. Flipping the mouse X coordinate is easier.
-  point.x = MirroredXCoordinateInsideView(point.x);
-  CRect drag_rect(kDownloadIconOffset -
+  point.set_x(MirroredXCoordinateInsideView(point.x()));
+  gfx::Rect drag_rect(kDownloadIconOffset -
                   parent_->big_icon_offset(),
                   0,
                   kDownloadIconOffset -
                   parent_->big_icon_offset() +
                   parent_->big_icon_size() + kInfoPadding +
                   kFilenameSize,
                   parent_->big_icon_size());
 
-  if (drag_rect.PtInRect(point)) {
+  if (drag_rect.Contains(point)) {
     SkBitmap* icon = parent_->LookupIcon(model_);
     if (icon)
       download_util::DragDownload(model_, icon);
   }
 
   return true;
 }
 
+void DownloadItemTabView::ShowContextMenu(View* source,
+                                      int x,
+                                      int y,
+                                      bool is_mouse_gesture) {
+  // Only show context menu when an item has been selected.
+  if (parent_->selected_index() != -1) {
+    gfx::Point location (x, y);
+    download_util::DownloadDestinationContextMenu menu(
+      model_, GetWidget()->GetHWND(), location.ToPOINT());
+  }
+}
+
 void DownloadItemTabView::LinkActivated(views::Link* source, int event_flags) {
   // There are several links in our view that could have been clicked:
   if (source == file_name_) {
     views::Widget* widget = this->GetWidget();
     HWND parent_window = widget ? widget->GetHWND() : NULL;
     model_->manager()->OpenDownloadInShell(model_, parent_window);
   } else if (source == pause_) {
     model_->TogglePause();
   } else if (source == cancel_) {
     model_->Cancel(true /* update history service */);
@@ skipping 401 matching lines @@
 
 bool DownloadTabView::ItemIsSelected(DownloadItem* download) {
   OrderedDownloads::iterator it = find(downloads_.begin(),
                                        downloads_.end(),
                                        download);
   if (it != downloads_.end())
     return selected_index_ == static_cast<int>(it - downloads_.begin());
   return false;
 }
 
+void DownloadTabView::SelectItemAtIndex(int index) {
+  if (selected_index() == -1)
+    ItemBecameSelected(downloads_[total_downloads() - 1]);
+  else if (index >= 0 && index < total_downloads())
+    ItemBecameSelected(downloads_[index]);
+}
+
 void DownloadTabView::SchedulePaintForViewAtIndex(int index) {
   int y = GetYPositionForIndex(index);
   SchedulePaint(0, y, width(), big_icon_size_);
 }
 
 int DownloadTabView::GetYPositionForIndex(int index) {
   int row = static_cast<int>(downloads_.size()) - 1 - index;
   return row * (big_icon_size_ + kSpacer) + kSpacer;
 }
 
@@ skipping 137 matching lines @@
     case NOTIFY_DOWNLOAD_STOP:
       DCHECK(profile()->HasCreatedDownloadManager());
       contents_->SetIsLoading(
           profile()->GetDownloadManager()->in_progress_count() > 0,
           NULL);
       break;
     default:
       break;
   }
 }