Issue 13244: Fixes to IA32 code generator to cope with new

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13244: Fixes to IA32 code generator to cope with new (Closed)

Created:
12 years ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixes to IA32 code generator to cope with new code generation machinery. Committed: http://code.google.com/p/v8/source/detail?r=935

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	src/regexp-macro-assembler-ia32.cc	View		4 chunks	+9 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

12 years ago (2008-12-08 10:25:44 UTC) #2

LGTM

http://codereview.chromium.org/13244/diff/1/2
File src/regexp-macro-assembler-ia32.cc (right):

http://codereview.chromium.org/13244/diff/1/2#newcode666
Line 666: __ lea(eax, Operand(edi, cp_offset));
You can use char_size() to generalize code that only differ on character size,
not opcode, without switching on mode:
 __ lea(eax, Operand(edi, cp_offset * char_size());

Expand Messages | Collapse Messages