Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: src/regexp-macro-assembler-ia32.cc

Issue 13244: Fixes to IA32 code generator to cope with new (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp-macro-assembler-ia32.cc
===================================================================
--- src/regexp-macro-assembler-ia32.cc (revision 930)
+++ src/regexp-macro-assembler-ia32.cc (working copy)
@@ -150,7 +150,7 @@
__ movzx_b(ebx, Operand(ecx, ebx, times_1, 0));
__ and_(eax, (1<<3)-1);
__ bt(Operand(ebx), eax);
- __ j(carry, on_zero);
+ BranchOrBacktrack(carry, on_zero);
}
@@ -203,7 +203,7 @@
__ cmpw(Operand(esi, edi, times_1, byte_offset + i * sizeof(uc16)),
Immediate(str[i]));
}
- __ j(not_equal, on_failure);
+ BranchOrBacktrack(not_equal, on_failure);
}
return;
}
@@ -574,7 +574,7 @@
void RegExpMacroAssemblerIA32::GoTo(Label* to) {
- __ jmp(to);
+ BranchOrBacktrack(no_condition, to);
}
@@ -662,7 +662,12 @@
if (cp_offset == 0) {
__ mov(register_location(reg), edi);
} else {
- __ lea(eax, Operand(edi, cp_offset));
+ if (mode_ == ASCII) {
+ __ lea(eax, Operand(edi, cp_offset));
Lasse Reichstein 2008/12/08 10:25:44 You can use char_size() to generalize code that on
+ } else {
+ ASSERT(mode_ == UC16);
+ __ lea(eax, Operand(edi, 2 * cp_offset));
+ }
__ mov(register_location(reg), eax);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698