Issue 132045: Re-enable the --enable-extensions flag. Fix a bunch of bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132045: Re-enable the --enable-extensions flag. Fix a bunch of bugs (Closed)

Created:
11 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews, Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Re-enable the --enable-extensions flag. Fix a bug where the extensions.enable pref was not being honored. Add tests. This is intended to be submitted after: http://codereview.chromium.org/132003 BUG=13467 TEST=Added unit tests

Patch Set 1 #

Patch Set 2 : Moved the browser_view.cc change to a different patch. #

Patch Set 3 : rebase #

Patch Set 4 : unblech #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -7 lines)			Patch
M	chrome/browser/extensions/extension_uitest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1 2	4 chunks	+13 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	1 2 3	4 chunks	+31 lines, -1 line	0 comments	Download
M	chrome/browser/profile.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

11 years, 6 months ago (2009-06-19 22:21:55 UTC) #2

should you change the check in browser_render_process_host.cc to use this flag?

Expand Messages | Collapse Messages