Issue 132003: Disable extensions besides externally installed ones and themes.

Issue 132003: Disable extensions besides externally installed ones and themes. (Closed)

Created:
11 years, 6 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews, Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Disable extensions besides externally installed ones and themes. This is mainly intended to be pulled to the 3.0 branch. It won't be submitted until another corresponding change to undo the damage is ready. BUG=13467 TEST=Added unit tests

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update error ui #

Patch Set 3 : Add somewhat unrelated unit test #

Patch Set 4 : Enable extensions in the renderer process no matter how they got installed #

Total comments: 1

Patch Set 5 : Fix bug where ExtensionShelf not shown when --enable-extensions not present #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : Fix ui test bustage #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+337 lines, -303 lines)			Patch
M	base/crypto/rsa_private_key_unittest.cc	View		2 chunks	+258 lines, -258 lines	0 comments	Download
M	chrome/browser/extensions/extension_uitest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.h	View	1 2 3 4 5 6 7	3 chunks	+11 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1 2 3 4 5	4 chunks	+28 lines, -27 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View	1 2 3 4 5 6	6 chunks	+15 lines, -6 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	4 5 6 7	3 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	5 6 7	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

http://codereview.chromium.org/132003/diff/1/2 File chrome/browser/extensions/extensions_service.cc (right): http://codereview.chromium.org/132003/diff/1/2#newcode1103 Line 1103: location != Extension::EXTERNAL_REGISTRY) This will lead to kind ...

11 years, 6 months ago (2009-06-18 14:49:10 UTC) #2

Aaron Boodman

11 years, 6 months ago (2009-06-18 19:09:08 UTC) #3

Aaron Boodman

FYI, I added a somewhat unrelated unit test, verifying EXTENSIONS_READY works.

11 years, 6 months ago (2009-06-18 21:40:55 UTC) #5

Aaron Boodman

FYI, I updated browser_render_process_host.cc to properly support extensions, even when --enable-extensions is disabled (eg for ...

11 years, 6 months ago (2009-06-18 23:43:19 UTC) #6

Erik does not do reviews

11 years, 6 months ago (2009-06-19 00:04:54 UTC) #8

LGTM with this change

http://codereview.chromium.org/132003/diff/12/1018
File chrome/browser/renderer_host/browser_render_process_host.cc (right):

http://codereview.chromium.org/132003/diff/12/1018#newcode296
Line 296: if (profile()->GetExtensionsService()->extensions()->size() > 0)
as I said offline, I think you should ask ExtensionPrefs what the number of
installed extensions are rather than asking ExtensionsService how many
extensions have been loaded.

Expand Messages | Collapse Messages