Add a gyp "buildtype" variable to differentiate official release builds.

Add a gyp "buildtype" variable to differentiate official release builds.

This notion was previously overloaded on "branding", but as implied, that
variable should really just control the "Google Chrome" vs. "Chromium"
branding. We need a separate setting to distinguish between "release" builds
(which get special handling, like breakpad symbol processing), and "everyday"
builds, like the buildbot continuous builds or personal developer builds.

This fixes a problem where the "Google Chrome" continuous builder was
unnecessarily trying to upload breakpad symbols for every single build.

[Nicolas Sylvain, 2009-06-18 22:40:25]

great, lgtm. Do you plan to make the buildbot change too or you want me to do
it?

[Michael Moss, 2009-06-18 22:42:47]

On 2009/06/18 22:40:25, Nicolas Sylvain wrote:
> great, lgtm. Do you plan to make the buildbot change too or you want me to do
> it?

I have to do that in a separate CL since it's outside my git client :(

[TVL, 2009-06-19 12:27:30]

http://codereview.chromium.org/132038/diff/6/1002
File chrome/chrome.gyp (right):

http://codereview.chromium.org/132038/diff/6/1002#newcode2405
Line 2405: ['branding=="Chrome" and buildtype=="Official"', {
I guess I'm confused, why key off both?  the summary implied buildtype was gonna
be the thing to key off of for this sorta stuff, but you're checking both?

For this to really work, you also need to map buildtype into a CPP symbol so the
code that enables breakpad gets compiled in?

[Michael Moss, 2009-06-22 17:30:14]

http://codereview.chromium.org/132038/diff/6/1002
File chrome/chrome.gyp (right):

http://codereview.chromium.org/132038/diff/6/1002#newcode2405
Line 2405: ['branding=="Chrome" and buildtype=="Official"', {
On 2009/06/19 12:27:31, TVL wrote:
> I guess I'm confused, why key off both?  the summary implied buildtype was
gonna
> be the thing to key off of for this sorta stuff, but you're checking both?
> 
> For this to really work, you also need to map buildtype into a CPP symbol so
the
> code that enables breakpad gets compiled in?

Done.