Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3244)

Unified Diff: chrome/chrome.gyp

Issue 132038: Add a gyp "buildtype" variable to differentiate official release builds. (Closed)
Patch Set: Fix logic again Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp
index 570f3c7e3f09e6593df877c65ff367d4313275ca..3c287dc62dbbeb373aa8b91ec6b547ae484c01ab 100644
--- a/chrome/chrome.gyp
+++ b/chrome/chrome.gyp
@@ -2417,7 +2417,9 @@
'conditions': [
['OS=="linux"', {
'conditions': [
- ['branding=="Chrome"', {
+ # All Chrome builds have breakpad symbols, but only process the
+ # symbols from official builds.
+ ['branding=="Chrome" and buildtype=="Official"', {
'actions': [
{
'action_name': 'dump_symbols',
@@ -3892,6 +3894,7 @@
}],
['OS=="linux"', {
'conditions': [
+ # Only Chrome builds get breakpad since crash processing is internal.
['branding=="Chrome"', {
'variables': {
'linux_breakpad%': 1,
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698