Issue 132031: Disk cache: First pass to add support for sparse entries....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132031: Disk cache: First pass to add support for sparse entries.... (Closed)

Created:
11 years, 6 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Disk cache: First pass to add support for sparse entries. Adding Read/Write support. BUG=12258 TEST=unittests. original review: http://codereview.chromium.org/126179 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18772

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1603 lines, -14 lines)			Patch
M	net/base/io_buffer.h	View		1 chunk	+37 lines, -2 lines	0 comments	Download
M	net/base/io_buffer.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	net/disk_cache/bitmap.h	View		1 chunk	+153 lines, -0 lines	0 comments	Download
A	net/disk_cache/bitmap.cc	View	1	1 chunk	+282 lines, -0 lines	0 comments	Download
A	net/disk_cache/bitmap_unittest.cc	View		1 chunk	+293 lines, -0 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.h	View		4 chunks	+22 lines, -2 lines	0 comments	Download
M	net/disk_cache/disk_cache_test_util.cc	View		3 chunks	+11 lines, -1 line	0 comments	Download
M	net/disk_cache/disk_format.h	View		2 chunks	+60 lines, -1 line	0 comments	Download
M	net/disk_cache/entry_impl.h	View		5 chunks	+11 lines, -4 lines	0 comments	Download
M	net/disk_cache/entry_impl.cc	View		5 chunks	+36 lines, -4 lines	0 comments	Download
M	net/disk_cache/entry_unittest.cc	View		2 chunks	+135 lines, -0 lines	0 comments	Download
A	net/disk_cache/sparse_control.h	View		1 chunk	+147 lines, -0 lines	0 comments	Download
A	net/disk_cache/sparse_control.cc	View		1 chunk	+407 lines, -0 lines	0 comments	Download
M	net/net.gyp	View		3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

rvargas (doing something else)

Patch set #1 is the result of the original code review (http://codereview.chromium.org/126179). Patch set #2 ...

11 years, 6 months ago (2009-06-18 22:05:25 UTC) #1

LGTM on the changes.