Disable extensions besides externally installed ones and themes.

chrome/browser/extensions/extensions_service.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extensions_service.h"
 
 #include "app/l10n_util.h"
 #include "base/command_line.h"
 #include "base/crypto/signature_verifier.h"
 #include "base/file_util.h"
@@ skipping 198 matching lines @@
   // already.
   bool got_response_;
 };
 
 ExtensionsService::ExtensionsService(Profile* profile,
                                      MessageLoop* frontend_loop,
                                      MessageLoop* backend_loop)
     : extension_prefs_(new ExtensionPrefs(profile->GetPrefs())),
       backend_loop_(backend_loop),
       install_directory_(profile->GetPath().AppendASCII(kInstallDirectoryName)),
-      extensions_enabled_(
-          CommandLine::ForCurrentProcess()->
-          HasSwitch(switches::kEnableExtensions)),
+      extensions_enabled_(false),
       show_extensions_prompts_(true),
       ready_(false) {
   // We pass ownership of this object to the Backend.
   DictionaryValue* extensions = extension_prefs_->CopyCurrentExtensions();
   backend_ = new ExtensionsServiceBackend(
           install_directory_, g_browser_process->resource_dispatcher_host(),
-          frontend_loop, extensions);
+          frontend_loop, extensions, extensions_enabled());
 }
 
 ExtensionsService::~ExtensionsService() {
   UnloadAllExtensions();
 }
 
+void ExtensionsService::SetExtensionsEnabled(bool enabled) {
+  extensions_enabled_ = true;
+  backend_loop_->PostTask(FROM_HERE, NewRunnableMethod(backend_.get(),
+    &ExtensionsServiceBackend::set_extensions_enabled, enabled));
+}
+
 void ExtensionsService::Init() {
   DCHECK(extensions_.size() == 0);
 
   // Start up the extension event routers.
   ExtensionBrowserEventRouter::GetInstance()->Init();
 
   LoadAllExtensions();
 
   // TODO(erikkay) this should probably be deferred to a future point
   // rather than running immediately at startup.
@@ skipping 102 matching lines @@
   ready_ = true;
   NotificationService::current()->Notify(
       NotificationType::EXTENSIONS_READY,
       Source<ExtensionsService>(this),
       NotificationService::NoDetails());
 }
 
 void ExtensionsService::OnExtensionsLoaded(ExtensionList* new_extensions) {
   scoped_ptr<ExtensionList> cleanup(new_extensions);
 
-  // Filter out any extensions we don't want to enable. Themes are always
-  // enabled, but other extensions are only loaded if --enable-extensions is
-  // present.
+  // Filter out any extensions that shouldn't be loaded. Themes are always
+  // loaded, but other extensions are only loaded if the extensions system is
+  // enabled.
   ExtensionList enabled_extensions;
   for (ExtensionList::iterator iter = new_extensions->begin();
        iter != new_extensions->end(); ++iter) {
-    if (extensions_enabled() || (*iter)->IsTheme()) {
+    if (extensions_enabled() || (*iter)->IsTheme() ||
+        (*iter)->location() == Extension::EXTERNAL_REGISTRY) {
       Extension* old = GetExtensionById((*iter)->id());
       if (old) {
         if ((*iter)->version()->CompareTo(*(old->version())) > 0) {
           // To upgrade an extension in place, unload the old one and
           // then load the new one.
           // TODO(erikkay) issue 12399
           UnloadExtension(old->id());
         } else {
           // We already have the extension of the same or older version.
           LOG(WARNING) << "Duplicate extension load attempt: " << (*iter)->id();
@@ skipping 70 matching lines @@
     Extension::Location location, ExternalExtensionProvider* test_provider) {
   backend_loop_->PostTask(FROM_HERE, NewRunnableMethod(backend_.get(),
       &ExtensionsServiceBackend::SetProviderForTesting,
       location, test_provider));
 }
 
 // ExtensionsServicesBackend
 
 ExtensionsServiceBackend::ExtensionsServiceBackend(
     const FilePath& install_directory, ResourceDispatcherHost* rdh,
-    MessageLoop* frontend_loop, DictionaryValue* extension_prefs)
+    MessageLoop* frontend_loop, DictionaryValue* extension_prefs,
+    bool extensions_enabled)
         : frontend_(NULL),
           install_directory_(install_directory),
           resource_dispatcher_host_(rdh),
           alert_on_error_(false),
-          frontend_loop_(frontend_loop) {
+          frontend_loop_(frontend_loop),
+          extensions_enabled_(false) {
   external_extension_providers_[Extension::EXTERNAL_PREF] =
       linked_ptr<ExternalExtensionProvider>(
           new ExternalPrefExtensionProvider(extension_prefs));
 #if defined(OS_WIN)
   external_extension_providers_[Extension::EXTERNAL_REGISTRY] =
       linked_ptr<ExternalExtensionProvider>(
           new ExternalRegistryExtensionProvider());
 #endif
 }
 
@@ skipping 479 matching lines @@
     const std::vector< Tuple2<SkBitmap, FilePath> >& images) {
   Extension extension;
   std::string error;
   if (!extension.InitFromValue(manifest,
                                true,  // require ID
                                &error)) {
     ReportExtensionInstallError(extension_path, "Invalid extension manifest.");
     return;
   }
 
-  if (!frontend_->extensions_enabled() && !extension.IsTheme()) {
-#if defined(OS_WIN)
-    if (frontend_->show_extensions_prompts()) {
-      win_util::MessageBox(GetForegroundWindow(),
-          L"Extensions are not enabled. Add --enable-extensions to the "
-          L"command-line to enable extensions.\n\n"
-          L"This is a temporary message and it will be removed when extensions "
-          L"UI is finalized.",
-          l10n_util::GetString(IDS_PRODUCT_NAME).c_str(), MB_OK);
-    }
-#endif
-    ReportExtensionInstallError(extension_path,
-        "Extensions are not enabled.");
-    return;
-  }
-
   Extension::Location location = Extension::INTERNAL;
   LookupExternalExtension(extension.id(), NULL, &location);
+
+  // We currently only allow themes and registry-installed extensions to be
+  // installed.
+  if (!extensions_enabled_ &&
+      !extension.IsTheme() &&
+      location != Extension::EXTERNAL_REGISTRY) {
+    ReportExtensionInstallError(extension_path,
+                                "Extensions are not enabled (yet!)");
+    return;
+  }
+
 #if defined(OS_WIN)
-  bool from_external = Extension::IsExternalLocation(location);
-
-  if (!extension.IsTheme() && !from_external &&
+  if (!extension.IsTheme() &&
+      !Extension::IsExternalLocation(location) &&
       frontend_->show_extensions_prompts() &&
       win_util::MessageBox(GetForegroundWindow(),
           L"Are you sure you want to install this extension?\n\n"
           L"This is a temporary message and it will be removed when extensions "
           L"UI is finalized.",
           l10n_util::GetString(IDS_PRODUCT_NAME).c_str(),
           MB_OKCANCEL) != IDOK) {
     ReportExtensionInstallError(extension_path,
         "User did not allow extension to be installed.");
     return;
@@ skipping 282 matching lines @@
   Extension::InstallType install_type =
       CompareToInstalledVersion(id, version->GetString(), &current_version);
 
   if (install_type == Extension::DOWNGRADE)
     return false;
 
   return (install_type == Extension::UPGRADE ||
           install_type == Extension::NEW_INSTALL ||
           NeedsReinstall(id, current_version));
 }