Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 132002: Make some small Mac-specific modifications to V8 to make it work on MacOS X 1... (Closed)

Created:
11 years, 6 months ago by iposva
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make some small Mac-specific modifications to V8 to make it work on MacOS X 10.4 rather than just 10.5 and up. 1: Set the right compile flags and predefines to get backward compatible Unix system calls. 2: Explicitly weak import the functions in execinfo.h and check at runtime to see if that library loaded before calling backtrace(). Original change submitted by maf@google.com and reviewed at http://codereview.chromium.org/126241. Committed: http://code.google.com/p/v8/source/detail?r=2213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M SConstruct View 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform-macos.cc View 4 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
iposva
TBR=ager
11 years, 6 months ago (2009-06-18 00:19:23 UTC) #1
Mads Ager (chromium)
11 years, 6 months ago (2009-06-18 05:27:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698