Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 126241: Make some small Mac-specific modifications to V8 to make it work on MacOS X 1... (Closed)

Created:
11 years, 6 months ago by maf
Modified:
9 years, 7 months ago
Reviewers:
iposva, Ivan Posva
CC:
v8-dev
Visibility:
Public.

Description

Make some small Mac-specific modifications to V8 to make it work on MacOS X 10.4 rather than just 10.5 and up. 1: Set the right compile flags and predefines to get backward compatible Unix system calls. 2: Explicitly weak import the functions in execinfo.h and check at runtime to see if that library loaded before calling backtrace().

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M SConstruct View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/platform-macos.cc View 4 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maf
11 years, 6 months ago (2009-06-16 23:44:13 UTC) #1
iposva
LGTM after comments. Please verify that the modifications do work for you, upload a new ...
11 years, 6 months ago (2009-06-17 21:03:23 UTC) #2
maf
11 years, 6 months ago (2009-06-18 00:01:35 UTC) #3
maf
11 years, 6 months ago (2009-06-18 00:03:24 UTC) #4
On 2009/06/18 00:01:35, maf wrote:
> 

Done. . Removed the CPPDEFINES and just as you said, it still works on 10.4.
Thanks.

Powered by Google App Engine
This is Rietveld 408576698