Issue 1315009: Make DidProcessCrash a bit more solid and accurate on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315009: Make DidProcessCrash a bit more solid and accurate on Windows (Closed)

Created:
10 years, 9 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Visibility:
Public.

Description

Make DidProcessCrash a bit more solid and accurate on Windows I hit the NOTREACHED() inside it while debugging an unrelated problem. Also, now there is one less special case in this function's contract. TEST=none BUG=38048 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43706

Patch Set 1 #

Patch Set 2 : now with a test #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -14 lines)			Patch
M	base/process_util.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	base/process_util_unittest.cc	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	base/process_util_win.cc	View	1 chunk	+18 lines, -4 lines	0 comments	Download
M	chrome/browser/child_process_launcher.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/nacl_host/nacl_process_host.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

care to add a test? On 2010/03/25 16:00:03, Paweł Hajdan Jr. wrote: >

10 years, 9 months ago (2010-03-25 21:07:27 UTC) #2

Paweł Hajdan Jr.

Added a very basic test, but it verifies the changes made in this CL.

10 years, 9 months ago (2010-03-27 09:27:23 UTC) #3

Paweł Hajdan Jr.

On 2010/03/27 09:27:23, Paweł Hajdan Jr. wrote: > Added a very basic test, but it ...

10 years, 8 months ago (2010-03-30 19:29:31 UTC) #4

lgtm

Expand Messages | Collapse Messages