chrome/browser/child_process_launcher.cc - Issue 1315009: Make DidProcessCrash a bit more solid and accurate on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/child_process_launcher.cc

Issue 1315009: Make DidProcessCrash a bit more solid and accurate on Windows (Closed)

Patch Set: now with a test Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/child_process_launcher.cc

diff --git a/chrome/browser/child_process_launcher.cc b/chrome/browser/child_process_launcher.cc

index ff555fedb9b1161600e55f3cfadfdc8e1691599b..206d8a788daab8cef1b5765d90f777c674bad57d 100644

--- a/chrome/browser/child_process_launcher.cc

+++ b/chrome/browser/child_process_launcher.cc

@@ -312,8 +312,6 @@ bool ChildProcessLauncher::DidProcessCrash() {

// DidProcessCrash called waitpid with WNOHANG, it'll reap the process.

// However, if DidProcessCrash didn't reap the child, we'll need to in

// Terminate via ProcessWatcher. So we can't close the handle here.

- //

- // This is moot on Windows where |child_exited| will always be true.

if (child_exited)

context_->process_.Close();

« no previous file with comments | « base/process_util_win.cc ('k') | chrome/browser/nacl_host/nacl_process_host.cc » ('j') | no next file with comments »