Add GetMessageHandlers to HtmlDialogUIDelegate to allow...

Add a 'RegisterMessages' function to DOMMessageHandler to make it easy to construct these objects by deferring the DOMUI dependency to the init / "Attach" step.

Add GetMessageHandlers to HtmlDialogUIDelegate to allow
sending/receiving messages to the page hosted in the dialog as opposed to only on open/close.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19359

[brettw, 2009-06-23 21:34:58]

LGTM

http://codereview.chromium.org/131094/diff/2025/2041
File chrome/browser/chrome_plugin_host.cc (right):

http://codereview.chromium.org/131094/diff/2025/2041#newcode317
Line 317: std::vector<DOMMessageHandler*>* handlers) const { }
I recently discovered that the style guide stipulates {} with no space in this
situation.

http://codereview.chromium.org/131094/diff/2025/2031
File chrome/browser/dom_ui/html_dialog_ui.cc (right):

http://codereview.chromium.org/131094/diff/2025/2031#newcode73
Line 73: std::vector<DOMMessageHandler*>::iterator it = handlers.begin();
We'd normally just put this inside the for loop and put the other conditions
inside it on the next line.

http://codereview.chromium.org/131094/diff/2025/2033
File chrome/browser/dom_ui/html_dialog_ui.h (right):

http://codereview.chromium.org/131094/diff/2025/2033#newcode28
Line 28: // Get DOMMessageHandler objects to handle messages from the HTML/JS
page.
Can you expand on this a bit? I think one sentence saying what the handlers do,
and one about the lifetime of the pointers in the vector would be good.

[tim (not reviewing), 2009-06-25 20:22:51]

On 2009/06/23 21:34:58, brettw wrote:
> LGTM
> 
> http://codereview.chromium.org/131094/diff/2025/2041
> File chrome/browser/chrome_plugin_host.cc (right):
> 
> http://codereview.chromium.org/131094/diff/2025/2041#newcode317
> Line 317: std::vector<DOMMessageHandler*>* handlers) const { }
> I recently discovered that the style guide stipulates {} with no space in this
> situation.
> 
> http://codereview.chromium.org/131094/diff/2025/2031
> File chrome/browser/dom_ui/html_dialog_ui.cc (right):
> 
> http://codereview.chromium.org/131094/diff/2025/2031#newcode73
> Line 73: std::vector<DOMMessageHandler*>::iterator it = handlers.begin();
> We'd normally just put this inside the for loop and put the other conditions
> inside it on the next line.
> 
> http://codereview.chromium.org/131094/diff/2025/2033
> File chrome/browser/dom_ui/html_dialog_ui.h (right):
> 
> http://codereview.chromium.org/131094/diff/2025/2033#newcode28
> Line 28: // Get DOMMessageHandler objects to handle messages from the HTML/JS
> page.
> Can you expand on this a bit? I think one sentence saying what the handlers
do,
> and one about the lifetime of the pointers in the vector would be good.

All done, and actually added the call to AddMessageHandler in
html_dialog_view.cc, which I forgot earlier.