Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Unified Diff: chrome/browser/dom_ui/history_ui.cc

Issue 131094: Add GetMessageHandlers to HtmlDialogUIDelegate to allow... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/history_ui.h ('k') | chrome/browser/dom_ui/html_dialog_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/history_ui.cc
===================================================================
--- chrome/browser/dom_ui/history_ui.cc (revision 19317)
+++ chrome/browser/dom_ui/history_ui.cc (working copy)
@@ -96,17 +96,9 @@
// HistoryHandler
//
////////////////////////////////////////////////////////////////////////////////
-BrowsingHistoryHandler::BrowsingHistoryHandler(DOMUI* dom_ui)
- : DOMMessageHandler(dom_ui),
- search_text_(),
+BrowsingHistoryHandler::BrowsingHistoryHandler()
+ : search_text_(),
remover_(NULL) {
- dom_ui_->RegisterMessageCallback("getHistory",
- NewCallback(this, &BrowsingHistoryHandler::HandleGetHistory));
- dom_ui_->RegisterMessageCallback("searchHistory",
- NewCallback(this, &BrowsingHistoryHandler::HandleSearchHistory));
- dom_ui_->RegisterMessageCallback("deleteDay",
- NewCallback(this, &BrowsingHistoryHandler::HandleDeleteDay));
-
// Create our favicon data source.
g_browser_process->io_thread()->message_loop()->PostTask(FROM_HERE,
NewRunnableMethod(&chrome_url_data_manager,
@@ -124,6 +116,15 @@
remover_->RemoveObserver(this);
}
+void BrowsingHistoryHandler::RegisterMessages() {
+ dom_ui_->RegisterMessageCallback("getHistory",
+ NewCallback(this, &BrowsingHistoryHandler::HandleGetHistory));
+ dom_ui_->RegisterMessageCallback("searchHistory",
+ NewCallback(this, &BrowsingHistoryHandler::HandleSearchHistory));
+ dom_ui_->RegisterMessageCallback("deleteDay",
+ NewCallback(this, &BrowsingHistoryHandler::HandleDeleteDay));
+}
+
void BrowsingHistoryHandler::HandleGetHistory(const Value* value) {
// Anything in-flight is invalid.
cancelable_consumer_.CancelAllRequests();
@@ -356,7 +357,7 @@
////////////////////////////////////////////////////////////////////////////////
HistoryUI::HistoryUI(TabContents* contents) : DOMUI(contents) {
- AddMessageHandler(new BrowsingHistoryHandler(this));
+ AddMessageHandler((new BrowsingHistoryHandler())->Attach(this));
HistoryUIHTMLSource* html_source = new HistoryUIHTMLSource();
« no previous file with comments | « chrome/browser/dom_ui/history_ui.h ('k') | chrome/browser/dom_ui/html_dialog_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698