Issue 13087: Parameterize the "Hammer" subdirectory name in which we build as...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13087: Parameterize the "Hammer" subdirectory name in which we build as... (Closed)

Created:
12 years ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
tony, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Parameterize the "Hammer" subdirectory name in which we build as $BUILD_TARGET_DIR, so it can be set to "Debug" or "Release' to mimic Visual Studio, or whatever other subdirectory the user prefers. Fix PROGRESS= on Linux so the messages go to /dev/tty. Remove the now-unnecessary in-SCons support for --clobber. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6301

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	build/SConscript.main	View	1	5 chunks	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. Can you also remove the --clobber logic since we don't need it anymore?

12 years ago (2008-12-03 18:15:14 UTC) #2

sgk

12 years ago (2008-12-03 20:07:54 UTC) #3

On 2008/12/03 18:15:14, tony wrote:
> LGTM.
> 
> Can you also remove the --clobber logic since we don't need it anymore?

Done.

Expand Messages | Collapse Messages