Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: build/SConscript.main

Issue 13087: Parameterize the "Hammer" subdirectory name in which we build as... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.main
===================================================================
--- build/SConscript.main (revision 6274)
+++ build/SConscript.main (working copy)
@@ -7,11 +7,15 @@
import sys
+if sys.platform == 'win32':
+ console = 'con'
+else:
+ console = '/dev/tty'
p = ARGUMENTS.get('PROGRESS')
if p == 'spinner':
- Progress(['/\r', '|\r', '\\\r', '-\r'], interval=5, file=open('con', 'w'))
+ Progress(['/\r', '|\r', '\\\r', '-\r'], interval=5, file=open(console, 'w'))
elif p == 'name':
- Progress('$TARGET\r', overwrite=True, file=open('con', 'w'))
+ Progress('$TARGET\r', overwrite=True, file=open(console, 'w'))
default_warnings = ['no-missing-sconscript', 'no-no-parallel-support']
@@ -25,6 +29,13 @@
# or in the external environment when executing SCons, with the
# command line overriding any environment setting.
#
+# BUILD_TARGET_DIR
+# Specifies the target subdirectory name in which we'll
+# build everything. This is intended to mimic the Visual
+# Visual Studio "Debug\" and "Release\" subdirectories.
+# The default value is "Hammer."
+#
+#
# CHROME_BUILD_TYPE
# When set, applies settings from the file
# build\internal\release_impl${CHROME_BUILD_TYPE}.scons
@@ -45,6 +56,7 @@
#
clvars = Variables('scons.opts', ARGUMENTS)
clvars.AddVariables(
+ ('BUILD_TARGET_DIR', '', 'Hammer'),
('CHROME_BUILD_TYPE', '', os.environ.get('CHROME_BUILD_TYPE', '')),
('CHROMIUM_BUILD', '', os.environ.get('CHROMIUM_BUILD', '')),
BoolVariable('INCREMENTAL', '', os.environ.get('INCREMENTAL')),
@@ -64,7 +76,7 @@
all_system_libs = [],
CHROME_SRC_DIR = '$MAIN_DIR/..',
- DESTINATION_ROOT = '$MAIN_DIR/Hammer',
+ DESTINATION_ROOT = '$MAIN_DIR/$BUILD_TARGET_DIR',
# Where ComponentTestProgram() will build test executables.
TESTS_DIR = '$DESTINATION_ROOT',
@@ -588,17 +600,6 @@
)
-# Add --clobber (for the buildbot).
-# NOTE: seems to be crucial to do this before any builders are invoked.
-AddOption('--clobber', action='store_true', dest='clobber', default=False,
- help='Delete build directory before building.')
-if GetOption('clobber'):
- shutil.rmtree(root_env.Dir('$DESTINATION_ROOT').abspath, True)
- # sconsign file gets put here at the moment.
- shutil.rmtree(root_env.Dir('$MAIN_DIR/scons-out').abspath, True)
-
-
-
# -------------------------------------------------------------------------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698