Issue 1294002: Fix for negative routing info problem. We were replacing tokens after

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294002: Fix for negative routing info problem. We were replacing tokens after (Closed)

Created:
10 years, 9 months ago by ncarter (slow)

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, idana, Paweł Hajdan Jr., tim (not reviewing)

Visibility:
Public.

Description

Fix for negative routing info problem. We were replacing tokens after failure multiple times. BUG=39214 TEST=included new fancy unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42738

Patch Set 1 #

Patch Set 2 : Whitespace fix. #

Patch Set 3 : A different approach. #

Patch Set 4 : Added unit test and made fix work. #

Patch Set 5 : Added unit test and made fix work. #

Patch Set 6 : Comment fixes. #

Total comments: 1

Created: 10 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -14 lines)
M	chrome/browser/sync/engine/process_commit_response_command.cc	View	1 chunk	+2 lines, -2 lines	0 comments
M	chrome/browser/sync/engine/process_commit_response_command_unittest.cc	View	5 chunks	+86 lines, -4 lines	1 comment
M	chrome/browser/sync/sessions/status_controller.h	View	2 chunks	+13 lines, -2 lines	0 comments
M	chrome/test/sync/engine/syncer_command_test.h	View	3 chunks	+9 lines, -6 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

On 2010/03/24 20:41:28, timsteele wrote: > LGTM may want to tweak comment of extensions_activity_ in ...

10 years, 9 months ago (2010-03-24 20:42:46 UTC) #2

ncarter (slow)

Hi Tim, The fix actually works now (unlike the variant we came up with earlier) ...

10 years, 9 months ago (2010-03-25 01:35:11 UTC) #3

tim (not reviewing)

10 years, 9 months ago (2010-03-25 21:16:14 UTC) #4

LGTM!

http://codereview.chromium.org/1294002/diff/12001/13002
File chrome/browser/sync/engine/process_commit_response_command_unittest.cc
(right):

http://codereview.chromium.org/1294002/diff/12001/13002#newcode380
chrome/browser/sync/engine/process_commit_response_command_unittest.cc:380:
testing::Range(0, 1 << TEST_PARAM_BIT_COUNT));
this is cool

Expand Messages | Collapse Messages