Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: chrome/test/sync/engine/syncer_command_test.h

Issue 1294002: Fix for negative routing info problem. We were replacing tokens after (Closed)
Patch Set: Comment fixes. Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/sync/engine/syncer_command_test.h
diff --git a/chrome/test/sync/engine/syncer_command_test.h b/chrome/test/sync/engine/syncer_command_test.h
index a8814ac0824e55f460525eb6e8b6305d222a99fd..92175ed6c0064d89e5ae5077365de54860715d11 100644
--- a/chrome/test/sync/engine/syncer_command_test.h
+++ b/chrome/test/sync/engine/syncer_command_test.h
@@ -18,9 +18,10 @@ namespace browser_sync {
// A test fixture that simplifies writing unit tests for individual
// SyncerCommands, providing convenient access to a test directory
// and a syncer session.
-class SyncerCommandTest : public testing::Test,
- public sessions::SyncSession::Delegate,
- public ModelSafeWorkerRegistrar {
+template<typename T>
+class SyncerCommandTestWithParam : public testing::TestWithParam<T>,
+ public sessions::SyncSession::Delegate,
+ public ModelSafeWorkerRegistrar {
public:
// SyncSession::Delegate implementation.
virtual void OnSilencedUntil(const base::TimeTicks& silenced_until) {
@@ -51,8 +52,8 @@ class SyncerCommandTest : public testing::Test,
}
protected:
- SyncerCommandTest() {}
- virtual ~SyncerCommandTest() {}
+ SyncerCommandTestWithParam() {}
+ virtual ~SyncerCommandTestWithParam() {}
virtual void SetUp() {
syncdb_.SetUp();
context_.reset(new sessions::SyncSessionContext(NULL, NULL,
@@ -90,9 +91,11 @@ class SyncerCommandTest : public testing::Test,
scoped_ptr<sessions::SyncSession> session_;
std::vector<scoped_refptr<ModelSafeWorker> > workers_;
ModelSafeRoutingInfo routing_info_;
- DISALLOW_COPY_AND_ASSIGN(SyncerCommandTest);
+ DISALLOW_COPY_AND_ASSIGN(SyncerCommandTestWithParam);
};
+class SyncerCommandTest : public SyncerCommandTestWithParam<void*> {};
+
} // namespace browser_sync
#endif // CHROME_TEST_SYNC_ENGINE_SYNCER_COMMAND_TEST_H_

Powered by Google App Engine
This is Rietveld 408576698