Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 12880: Disk cache: Add support for an extra data stream for each cache entry.... (Closed)

Created:
12 years ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Disk cache: Add support for an extra data stream for each cache entry. This is the first step to allow the http cache to store additional metadata for certain entries. The cache file format changes to version 2.0 so an effect of this cl is that the borwser will discard the old cache files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6392

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+528 lines, -75 lines) Patch
A net/data/cache_tests/bad_entry/contents.txt View 1 chunk +66 lines, -0 lines 0 comments Download
M net/data/cache_tests/bad_entry/data_0 View Binary file 0 comments Download
M net/data/cache_tests/bad_entry/data_1 View Binary file 0 comments Download
M net/data/cache_tests/bad_entry/data_2 View Binary file 0 comments Download
M net/data/cache_tests/bad_entry/data_3 View Binary file 0 comments Download
M net/data/cache_tests/bad_entry/index View Binary file 0 comments Download
A net/data/cache_tests/bad_rankings/contents.txt View 1 chunk +66 lines, -0 lines 0 comments Download
M net/data/cache_tests/bad_rankings/data_0 View Binary file 0 comments Download
M net/data/cache_tests/bad_rankings/data_1 View Binary file 0 comments Download
M net/data/cache_tests/bad_rankings/data_2 View Binary file 0 comments Download
M net/data/cache_tests/bad_rankings/data_3 View Binary file 0 comments Download
M net/data/cache_tests/bad_rankings/index View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/index View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/index View Binary file 0 comments Download
A net/data/cache_tests/list_loop/contents.txt View 1 chunk +228 lines, -0 lines 0 comments Download
M net/data/cache_tests/list_loop/data_0 View Binary file 0 comments Download
M net/data/cache_tests/list_loop/data_1 View Binary file 0 comments Download
M net/data/cache_tests/list_loop/data_2 View Binary file 0 comments Download
M net/data/cache_tests/list_loop/data_3 View Binary file 0 comments Download
M net/data/cache_tests/list_loop/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_2 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_3 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/index View Binary file 0 comments Download
M net/disk_cache/backend_impl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/disk_cache/disk_format.h View 1 4 chunks +28 lines, -6 lines 0 comments Download
M net/disk_cache/entry_impl.h View 1 2 chunks +8 lines, -6 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 1 11 chunks +15 lines, -9 lines 0 comments Download
M net/disk_cache/entry_unittest.cc View 1 2 chunks +37 lines, -0 lines 1 comment Download
M net/disk_cache/mem_entry_impl.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M net/disk_cache/mem_entry_impl.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M net/disk_cache/rankings.h View 1 2 chunks +5 lines, -5 lines 1 comment Download
M net/disk_cache/rankings.cc View 1 12 chunks +40 lines, -36 lines 0 comments Download
M net/tools/dump_cache/dump_files.cc View 1 2 chunks +14 lines, -4 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
rvargas (doing something else)
12 years ago (2008-12-02 21:50:08 UTC) #1
Nicolas Sylvain
12 years ago (2008-12-04 18:52:28 UTC) #2
LGTM

http://codereview.chromium.org/12880/diff/341/676
File net/disk_cache/entry_unittest.cc (right):

http://codereview.chromium.org/12880/diff/341/676#newcode397
Line 397: EXPECT_EQ(net::ERR_INVALID_ARGUMENT,
you comment says :  // Tests IO on all valid streams.
but you are testing also on non-valid streams

http://codereview.chromium.org/12880/diff/341/678
File net/disk_cache/rankings.h (right):

http://codereview.chromium.org/12880/diff/341/678#newcode145
Line 145: LruData* control_data_;    // Data related to the LRU lists.
I think you have too many spaces here.

Powered by Google App Engine
This is Rietveld 408576698