Move test utility functions to a common place.

Move test utility functions to a common place.

Also removes the dev_mode flag from Firmware Image verification as key signature for the firmware should be checked whether or not dev mode is enabled.

BUG=670
TEST=All tests still pass.

Merge remote branch 'refs/remotes/origin/master' into fixtests


Fix tests, remove dev mode. Move common code.

[gauravsh, 2010-03-25 18:07:02]

ping?

On Wed, Mar 24, 2010 at 3:14 PM,  <gauravsh@chromium.org> wrote:
> Reviewers: Luigi Semenzato,
>
> Description:
> Move test utility functions to a common place.
>
> Also removes the dev_mode flag from Firmware Image verification as key
> signature
> for the firmware should be checked whether or not dev mode is enabled.
>
> BUG=670
> TEST=All tests still pass.
>
> Merge remote branch 'refs/remotes/origin/master' into fixtests
>
>
> Fix tests, remove dev mode. Move common code.
>
> Please review this at http://codereview.chromium.org/1280002
>
> Affected files:
>  M src/platform/vboot_reference/include/firmware_image.h
>  M src/platform/vboot_reference/include/kernel_image.h
>  M src/platform/vboot_reference/tests/Makefile
>  M src/platform/vboot_reference/tests/firmware_image_tests.c
>  M src/platform/vboot_reference/tests/firmware_rollback_tests.c
>  M src/platform/vboot_reference/tests/firmware_verify_benchmark.c
>  M src/platform/vboot_reference/tests/kernel_image_tests.c
>  M src/platform/vboot_reference/tests/kernel_verify_benchmark.c
>  M src/platform/vboot_reference/tests/test_common.h
>  M src/platform/vboot_reference/tests/test_common.c
>  M src/platform/vboot_reference/tests/verify_firmware_fuzz_driver.c
>  M src/platform/vboot_reference/utils/firmware_image.c
>  M src/platform/vboot_reference/utils/firmware_utility.cc
>
>
>



-- 
-g

[Luigi Semenzato, 2010-03-25 19:45:20]

LGTM after fixing minor indentation problem.

http://codereview.chromium.org/1280002/diff/1/13
File src/platform/vboot_reference/utils/firmware_image.c (right):

http://codereview.chromium.org/1280002/diff/1/13#newcode727
src/platform/vboot_reference/utils/firmware_image.c:727: return
BOOT_FIRMWARE_B_CONTINUE;
Indentation?