Store type information with constants. ...

Store type information with constants. 

Instead of testing the value of a constant frame element to determine
the type we compute its type information at construction time.

This speeds up querying the type information during code generation.

This change also adds support for Integer32 constants and sets 
the type information accordingly.


Committed: http://code.google.com/p/v8/source/detail?r=4256

[Lasse Reichstein, 2010-03-24 13:58:02]

LGTM

http://codereview.chromium.org/1277001/diff/6001/7003
File src/frame-element.h (right):

http://codereview.chromium.org/1277001/diff/6001/7003#newcode110
src/frame-element.h:110: : NumberInfo::HeapNumber();
Naming is inconsistent. Integer32 is a specification level type, and HeapNumber
is an implementation type. How about renaming HeapNumber to Double?

http://codereview.chromium.org/1277001/diff/6001/7003#newcode113
src/frame-element.h:113: }
No string types? :)

http://codereview.chromium.org/1277001/diff/6001/7002
File src/number-info.h (right):

http://codereview.chromium.org/1277001/diff/6001/7002#newcode118
src/number-info.h:118: if (value >= -0x80000000 && value <= 0xffffffff) {
Add "u" after 0xffffffff to make it explicit that it's unsigned.

http://codereview.chromium.org/1277001/diff/6001/7001
File src/register-allocator.h (right):

http://codereview.chromium.org/1277001/diff/6001/7001#newcode81
src/register-allocator.h:81: }
This code seems to exist in more than one version. How about making a function
in an -inl.h file for it?

[fschneider, 2010-03-24 15:26:25]

http://codereview.chromium.org/1277001/diff/6001/7003
File src/frame-element.h (right):

http://codereview.chromium.org/1277001/diff/6001/7003#newcode110
src/frame-element.h:110: : NumberInfo::HeapNumber();
On 2010/03/24 13:58:02, Lasse Reichstein wrote:
> Naming is inconsistent. Integer32 is a specification level type, and
HeapNumber
> is an implementation type. How about renaming HeapNumber to Double?

Yes, we have a mix here. I'm not sure what the best convention is here, but I
also like Double better.

http://codereview.chromium.org/1277001/diff/6001/7003#newcode113
src/frame-element.h:113: }
On 2010/03/24 13:58:02, Lasse Reichstein wrote:
> No string types? :)

I decided to not produce string type yet, since it is not yet used in the code
generator. I plan to add it as a separate change.

http://codereview.chromium.org/1277001/diff/6001/7002
File src/number-info.h (right):

http://codereview.chromium.org/1277001/diff/6001/7002#newcode118
src/number-info.h:118: if (value >= -0x80000000 && value <= 0xffffffff) {
On 2010/03/24 13:58:02, Lasse Reichstein wrote:
> Add "u" after 0xffffffff to make it explicit that it's unsigned.

Done.

http://codereview.chromium.org/1277001/diff/6001/7001
File src/register-allocator.h (right):

http://codereview.chromium.org/1277001/diff/6001/7001#newcode81
src/register-allocator.h:81: }
On 2010/03/24 13:58:02, Lasse Reichstein wrote:
> This code seems to exist in more than one version. How about making a function
> in an -inl.h file for it?

Done.