Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: src/ia32/codegen-ia32.cc

Issue 1277001: Store type information with constants. ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frame-element.h ('k') | src/number-info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/codegen-ia32.cc
===================================================================
--- src/ia32/codegen-ia32.cc (revision 4250)
+++ src/ia32/codegen-ia32.cc (working copy)
@@ -2704,8 +2704,8 @@
bool known_non_smi =
(left_side.is_constant() && !left_side.handle()->IsSmi()) ||
(right_side.is_constant() && !right_side.handle()->IsSmi()) ||
- left_side.number_info().IsHeapNumber() ||
- right_side.number_info().IsHeapNumber();
+ left_side.number_info().IsDouble() ||
+ right_side.number_info().IsDouble();
NaNInformation nan_info =
(CouldBeNaN(left_side) && CouldBeNaN(right_side)) ?
kBothCouldBeNaN :
@@ -2836,7 +2836,7 @@
Result* left_side,
Result* right_side) {
Label done;
- if (operand->number_info().IsHeapNumber()) {
+ if (operand->number_info().IsDouble()) {
// Operand is known to be a heap number, just load it.
__ fld_d(FieldOperand(operand->reg(), HeapNumber::kValueOffset));
} else if (operand->number_info().IsSmi()) {
@@ -2875,7 +2875,7 @@
Result* right_side,
JumpTarget* not_numbers) {
Label done;
- if (operand->number_info().IsHeapNumber()) {
+ if (operand->number_info().IsDouble()) {
// Operand is known to be a heap number, just load it.
__ movdbl(reg, FieldOperand(operand->reg(), HeapNumber::kValueOffset));
} else if (operand->number_info().IsSmi()) {
@@ -9929,7 +9929,7 @@
Label arg2_is_object, check_undefined_arg2;
Label load_arg2, done;
- if (!number_info.IsHeapNumber()) {
+ if (!number_info.IsDouble()) {
if (!number_info.IsSmi()) {
__ test(edx, Immediate(kSmiTagMask));
__ j(not_zero, &arg1_is_object);
@@ -9948,7 +9948,7 @@
// Here edx has the untagged integer, eax has a Smi or a heap number.
__ bind(&load_arg2);
- if (!number_info.IsHeapNumber()) {
+ if (!number_info.IsDouble()) {
// Test if arg2 is a Smi.
if (!number_info.IsSmi()) {
__ test(eax, Immediate(kSmiTagMask));
« no previous file with comments | « src/frame-element.h ('k') | src/number-info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698