Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: base/crypto/rsa_private_key_unittest.cc

Issue 1271002: Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInf... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/crypto/rsa_private_key_unittest.cc
===================================================================
--- base/crypto/rsa_private_key_unittest.cc (revision 42322)
+++ base/crypto/rsa_private_key_unittest.cc (working copy)
@@ -3,17 +3,12 @@
// found in the LICENSE file.
#include "base/crypto/rsa_private_key.h"
-#include "base/leak_annotations.h"
#include "base/scoped_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
// Generate random private keys with two different sizes. Reimport, then
// export them again. We should get back the same exact bytes.
TEST(RSAPrivateKeyUnitTest, InitRandomTest) {
- // This test currently leaks some memory,
- // see http://crbug.com/34742
- ANNOTATE_SCOPED_MEMORY_LEAK;
-
scoped_ptr<base::RSAPrivateKey> keypair1(base::RSAPrivateKey::Create(1024));
scoped_ptr<base::RSAPrivateKey> keypair2(base::RSAPrivateKey::Create(2048));
ASSERT_TRUE(keypair1.get());
@@ -53,10 +48,6 @@
// Verify that generated public keys look good. This test data was generated
// with the openssl command line tool.
TEST(RSAPrivateKeyUnitTest, PublicKeyTest) {
- // This test currently leaks some memory,
- // see http://crbug.com/34742
- ANNOTATE_SCOPED_MEMORY_LEAK;
-
const uint8 private_key_info[] = {
0x30, 0x82, 0x02, 0x78, 0x02, 0x01, 0x00, 0x30,
0x0d, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7,
@@ -194,10 +185,6 @@
//
// This test case verifies these two failures modes don't occur.
TEST(RSAPrivateKeyUnitTest, ShortIntegers) {
- // This test currently leaks some memory,
- // see http://crbug.com/34742
- ANNOTATE_SCOPED_MEMORY_LEAK;
-
const uint8 short_integer_with_high_bit[] = {
0x30, 0x82, 0x02, 0x77, 0x02, 0x01, 0x00, 0x30,
0x0d, 0x06, 0x09, 0x2a, 0x86, 0x48, 0x86, 0xf7,

Powered by Google App Engine
This is Rietveld 408576698