Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8664)

Unified Diff: base/crypto/rsa_private_key_nss.cc

Issue 1271002: Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInf... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/crypto/rsa_private_key_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/crypto/rsa_private_key_nss.cc
===================================================================
--- base/crypto/rsa_private_key_nss.cc (revision 42322)
+++ base/crypto/rsa_private_key_nss.cc (working copy)
@@ -11,6 +11,7 @@
#include <iostream>
#include <list>
+#include "base/leak_annotations.h"
#include "base/logging.h"
#include "base/nss_util.h"
#include "base/scoped_ptr.h"
@@ -63,6 +64,9 @@
// static
RSAPrivateKey* RSAPrivateKey::CreateFromPrivateKeyInfo(
const std::vector<uint8>& input) {
+ // This method currently leaks some memory.
+ // See http://crbug.com/34742.
+ ANNOTATE_SCOPED_MEMORY_LEAK;
scoped_ptr<RSAPrivateKey> result(new RSAPrivateKey);
PK11SlotInfo *slot = PK11_GetInternalSlot();
« no previous file with comments | « no previous file | base/crypto/rsa_private_key_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698