Issue 1271002: Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInf...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1271002: Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInf... (Closed)

Created:
10 years, 9 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews, brettw+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Annotated the scoped leak inside base::RSAPrivateKey::CreateFromPrivateKeyInfo, removed the annotations from the tests calling it (RSAPrivateKeyUnitTest.* and SignatureCreatorTest.BasicTest) BUG=34742 TBR=wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42459

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -17 lines)			Patch
M	base/crypto/rsa_private_key_nss.cc	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	base/crypto/rsa_private_key_unittest.cc	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	base/crypto/signature_creator_unittest.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

wtc

10 years, 9 months ago (2010-03-24 19:17:06 UTC) #1

LGTM.  Thanks!

http://codereview.chromium.org/1271002/diff/1/2
File base/crypto/rsa_private_key_nss.cc (right):

http://codereview.chromium.org/1271002/diff/1/2#newcode79
base/crypto/rsa_private_key_nss.cc:79: SECStatus rv = 
PK11_ImportDERPrivateKeyInfoAndReturnKey(slot,
If the annotation doesn't need to be at the beginning of a
function, it would be nice to put the annotation here because
the leak occurs in the PK11_ImportDERPrivateKeyInfoAndReturnKey
call.

It would be nice to reference NSS bug 518443 and note that
it's fixed in NSS 3.12.5, so that we know when we can remove
this annotation in the future.

Expand Messages | Collapse Messages