Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 12693003: Add support for mkv video files in Files.app. (Closed)

Created:
7 years, 9 months ago by mtomasz
Modified:
7 years, 9 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Add support for mkv video files in Files.app. Mkv files had been playable in Chrome, but not in Files.app, once they are downloaded. Thich patch sets Files.app as able to handle mkv files. TEST=Download an mkv video and try to play it in Files.app. BUG=175478 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187939

Patch Set 1 #

Patch Set 2 : Added support for apps v2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/file_manager/manifest.json View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/manifest_v1.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@yoshiki: PTAL.
7 years, 9 months ago (2013-03-13 05:42:03 UTC) #1
yoshiki
lgtm
7 years, 9 months ago (2013-03-13 05:58:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12693003/2001
7 years, 9 months ago (2013-03-13 06:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12693003/2001
7 years, 9 months ago (2013-03-13 19:02:11 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 20:42:31 UTC) #5
Message was sent while issue was closed.
Change committed as 187939

Powered by Google App Engine
This is Rietveld 408576698