Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 126221: Revert 18512 - Revert 18373 Consider a redirect following user gesture as us... (Closed)

Created:
11 years, 6 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
laforge
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 18512 - Revert 18373 Consider a redirect following user gesture as userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896, 12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -29 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.h View 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 6 chunks +50 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/History/history_length_test_page_1.html View 2 chunks +6 lines, -4 lines 0 comments Download
A + chrome/test/data/History/history_length_test_page_11.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/History/history_length_test_page_12.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/History/history_length_test_page_2.html View 1 chunk +4 lines, -3 lines 0 comments Download
A + chrome/test/data/History/history_length_test_page_21.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/History/history_length_test_page_22.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/History/history_length_test_page_3.html View 2 chunks +14 lines, -11 lines 0 comments Download
M chrome/test/data/History/history_length_test_page_4.html View 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/test/ui/history_uitest.cc View 4 chunks +61 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 6 months ago (2009-06-16 20:22:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698