Revert 18373 - Consider a redirect following user gesture as userinitiated in...

Revert 18373 - Consider a redirect following user gesture as userinitiated in maintaining
navigation entries. Also, ignore redirect or machineinitiated new subframe
navigations.

The current code treats all redirects as machineinitiated in processing
navigation to a new page (to fix Bugs 9663 and 10531). This is not always
appropriate, because some sites, e.g., www.google.com/ig, use redirect to
implement userinitiated navigation (Bug 11896).

This change assumes that a machineinitiated redirect happens within 300ms
since the last document load was completed, while  a userinitiated one
happens later.

This assumption is not always correct, e.g., a user may cause transition within
300ms. But I cannot think of any better ways to tell if a redirect is machine
initiated or userinitiated.

I believe this change works good enough, at least better than the status quo.

Review URL: http://codereview.chromium.org/115919

TEST=Open http://www.hp.com and observe it redirects to
http://www.hp.com/#Product . Hit Back button and observe
the former URL is not visited. Open http://www.google.com/ig and
click tabs inside the page, and try hitting Back and Forward to see if the
navigation is right. Open http://www.google.com/codesearch, search for
something, click on a result item, and try hitting Back.

BUG=11896, 12820
TBR=yuzo@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18512

[Yuzo, 2009-06-17 02:33:31]

Hi,

Now that we know 18373 hasn't broken:
  TabRestoreUITest.RestoreToDifferentWindow
, should 18512 be reverted?

Yuzo

[Yuzo, 2009-06-17 04:03:31]

Ah, sorry, you have reverted it already. Thanks!

Yuzo

On 2009/06/17 02:33:31, yuzo wrote:
> Hi,
> 
> Now that we know 18373 hasn't broken:
>   TabRestoreUITest.RestoreToDifferentWindow
> , should 18512 be reverted?
> 
> Yuzo