Issue 126175: Close all browsers during InProcessBrowserTest cleanup, not just the main one...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126175: Close all browsers during InProcessBrowserTest cleanup, not just the main one... (Closed)

Created:
11 years, 6 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Close all browsers during InProcessBrowserTest cleanup, not just the main one. BUG=none TEST=ExtensionViewTest.Incognito Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18466

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -40 lines)			Patch
M	chrome/browser/extensions/extension_browsertest.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/test/in_process_browser_test.h	View	4 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/test/in_process_browser_test.cc	View	3 chunks	+6 lines, -21 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 6 months ago (2009-06-16 00:04:48 UTC) #2

LGTM

http://codereview.chromium.org/126175/diff/1002/8
File chrome/test/in_process_browser_test.cc (right):

http://codereview.chromium.org/126175/diff/1002/8#newcode196
Line 196: for (; browser != BrowserList::end_last_active(); ++browser) {
nit: no {}

Expand Messages | Collapse Messages