Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9374)

Unified Diff: chrome/test/in_process_browser_test.h

Issue 126175: Close all browsers during InProcessBrowserTest cleanup, not just the main one... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/in_process_browser_test.h
===================================================================
--- chrome/test/in_process_browser_test.h (revision 18385)
+++ chrome/test/in_process_browser_test.h (working copy)
@@ -5,8 +5,6 @@
#ifndef CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
#define CHROME_TEST_IN_PROCESS_BROWSER_TEST_H_
-#include "chrome/common/notification_registrar.h"
-#include "chrome/common/notification_observer.h"
#include "net/url_request/url_request_unittest.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -39,7 +37,7 @@
// InProcessBrowserTest disables the sandbox when running.
//
// See ui_test_utils for a handful of methods designed for use with this class.
-class InProcessBrowserTest : public testing::Test, public NotificationObserver {
+class InProcessBrowserTest : public testing::Test {
public:
InProcessBrowserTest();
@@ -54,12 +52,6 @@
// Restores state configured in SetUp.
virtual void TearDown();
- // Used to track when the browser_ is destroyed. Resets the |browser_| field
- // to NULL.
- virtual void Observe(NotificationType type,
- const NotificationSource& source,
- const NotificationDetails& details);
-
protected:
// Returns the browser created by CreateBrowser.
Browser* browser() const { return browser_; }
@@ -98,9 +90,6 @@
// Browser created from CreateBrowser.
Browser* browser_;
- // Used to track when the browser is deleted.
- NotificationRegistrar registrar_;
-
// HTTPServer, created when StartHTTPServer is invoked.
scoped_refptr<HTTPTestServer> http_server_;

Powered by Google App Engine
This is Rietveld 408576698