Issue 126123: Modify regression test. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126123: Modify regression test. ... (Closed)

Created:
11 years, 6 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Modify regression test. Because of varying floating-point precision, the slow case is hard to test with explicit values. Instead, we check that sine and cosine do not return the same value (the regression was that the slow case of cosine accidentally did sine instead of cosine). Committed: http://code.google.com/p/v8/source/detail?r=2169

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	test/mjsunit/sin-cos.js	View		2 chunks	+9 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

That's annoying, but LGTM.

Expand Messages | Collapse Messages