Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: test/mjsunit/sin-cos.js

Issue 126123: Modify regression test. ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/sin-cos.js
===================================================================
--- test/mjsunit/sin-cos.js (revision 2166)
+++ test/mjsunit/sin-cos.js (working copy)
@@ -27,8 +27,8 @@
// Test Math.sin and Math.cos.
-var input_sin = [0, Math.PI, Math.PI / 6, Math.PI / 2, Math.pow(2, 70)];
-var input_cos = [0, Math.PI, Math.PI / 6, Math.PI / 2, Math.pow(2, 70)];
+var input_sin = [0, Math.PI, Math.PI / 6, Math.PI / 2];
+var input_cos = [0, Math.PI, Math.PI / 6, Math.PI / 2];
var output_sin = input_sin.map(Math.sin);
var output_cos = input_sin.map(Math.cos);
@@ -36,14 +36,17 @@
var expected_sin = [0,
1.2246063538223773e-16,
0.49999999999999994,
- 1,
- -0.9983193022079332];
+ 1];
var expected_cos = [1,
-1,
0.8660254037844387,
- 6.123031769111886e-17,
- 0.05795317798935058];
+ 6.123031769111886e-17];
assertArrayEquals(expected_sin, output_sin, "sine");
assertArrayEquals(expected_cos, output_cos, "cosine");
+
+// By accident, the slow case for sine and cosine were both sine at
+// some point. This is a regression test for that issue.
+var x = Math.pow(2, 70);
+assertTrue(Math.sin(x) != Math.cos(x));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698