Patch to solve the problem in import export bookmarks

This patch is to solve the problem in import/export bookmarks. They aren't exported correctly and also not imported
correctly. Now when the bookmarks are exported the character " are escaped to " and when they are imported,
they are unescaped.

BUG=7505
TEST=None

[PhistucK, 2009-06-12 11:08:14]

On 2009/06/12 04:31:09, tfarina wrote:
> 
And when there is an actual """ in the text, would it be automatically
escaped, too?
Should you not escape every "&" to "&" and unescape it accordingly?

Thank you for doing this!

[sky, 2009-06-12 15:03:44]

There are unit tests for both the bookmark writer and firefox2 importer, could
you extend them for coverage of these cases?

Thanks!

http://codereview.chromium.org/126036/diff/1/3
File chrome/browser/bookmarks/bookmark_html_writer.cc (right):

http://codereview.chromium.org/126036/diff/1/3#newcode169
Line 169: // Convert " to \"
can you update this comment.

http://codereview.chromium.org/126036/diff/1/2
File chrome/browser/importer/firefox2_importer.cc (right):

http://codereview.chromium.org/126036/diff/1/2#newcode452
Line 452: std::wstring w_url;
your spacing is off here. It should be 4 space indented.

http://codereview.chromium.org/126036/diff/1/2#newcode453
Line 453: std::wstring* p_url = &w_url;
nuke p_url and instead use &w_url.

[sky, 2009-06-15 22:45:56]

http://codereview.chromium.org/126036/diff/22/26
File chrome/browser/bookmarks/bookmark_html_writer_unittest.cc (right):

http://codereview.chromium.org/126036/diff/22/26#newcode120
Line 120: AssertBookmarkEntryEquals(parsed_bookmarks[2], false, url3,
url3_title, t3,
How does both this and the assertion you're adding work?

[sky, 2009-06-16 14:39:30]

LGTM

[tfarina (gmail-do not use), 2009-06-16 18:10:03]

On 2009/06/16 14:39:30, sky wrote:
> LGTM

Thanks!!

Sky, can you commit this to me?

[sky, 2009-06-24 16:25:52]

This patch only contains firefox2_importer. I need a patch that contains all
your changes.

Thanks,

  -Scott

[sky, 2009-06-26 17:09:26]

http://codereview.chromium.org/126036/diff/3004/2010
File chrome/browser/bookmarks/bookmark_html_writer.cc (right):

http://codereview.chromium.org/126036/diff/3004/2010#newcode174
Line 174: ASCIIToUTF16("""));
I noticed that with FireFox urls with " gets mapped to %22. Did you verify that
if we escape urls like this they are read in correctly by FF?

http://codereview.chromium.org/126036/diff/3004/2008
File chrome/browser/importer/firefox2_importer.cc (right):

http://codereview.chromium.org/126036/diff/3004/2008#newcode510
Line 510: if (end == std::string::npos)
this needs to change to end == attribute_list.size()

[tfarina (gmail-do not use), 2009-06-27 01:16:38]

http://codereview.chromium.org/126036/diff/3004/2010
File chrome/browser/bookmarks/bookmark_html_writer.cc (right):

http://codereview.chromium.org/126036/diff/3004/2010#newcode174
Line 174: ASCIIToUTF16("""));
On 2009/06/26 17:09:26, sky wrote:
> I noticed that with FireFox urls with " gets mapped to %22. Did you verify
that
> if we escape urls like this they are read in correctly by FF?
Not yet, but I will do this as soon as possible.

[tfarina (gmail-do not use), 2009-06-27 18:25:22]

On 2009/06/27 01:16:38, tfarina wrote:
> http://codereview.chromium.org/126036/diff/3004/2010
> File chrome/browser/bookmarks/bookmark_html_writer.cc (right):
> 
> http://codereview.chromium.org/126036/diff/3004/2010#newcode174
> Line 174: ASCIIToUTF16("""));
> On 2009/06/26 17:09:26, sky wrote:
I noticed that in FireFox both " and " are encoded to %22.
> > I noticed that with FireFox urls with " gets mapped to %22. Did you verify
> that
> > if we escape urls like this they are read in correctly by FF?
> Not yet, but I will do this as soon as possible.

[tfarina (gmail-do not use), 2009-06-28 00:40:36]

If the url have either " or " when it is imported in FireFox it is mapped
to %22 so in this case nothing is broken.

[sky, 2009-06-29 16:15:39]

Your patch no longer applies cleanly. Can you update to the latest, then upload
your patch and I'll try and apply it again.

Thanks!

  -Scott

[sky, 2009-06-29 18:09:43]

Compile failure:
http://build.chromium.org/buildbot/try-server/builders/linux/builds/7439/step...
.

[tfarina (gmail-do not use), 2009-06-29 18:18:03]

This error occurs because I accept the changes made in the last
revision and it's merged in my working copy cleaning my t4 variable.
So my t4 variable was deleted in this patch.
I will add it again.

[sky, 2009-06-30 21:01:50]

Landed in r19654.
Thanks!

  -Scott