Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: remoting/webapp/appsv2.patch

Issue 12566035: Added survey butter-bar to web-app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improved string grammar. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « remoting/webapp/all_js_load.gtestjs ('k') | remoting/webapp/jscompiler_hacks.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 diff --git a/remoting/webapp/event_handlers.js b/remoting/webapp/event_handlers. js 1 diff --git a/remoting/webapp/event_handlers.js b/remoting/webapp/event_handlers. js
2 index 5dfc368..f69d984 100644 2 index 5dfc368..f69d984 100644
3 --- a/event_handlers.js 3 --- a/event_handlers.js
4 +++ b/event_handlers.js 4 +++ b/event_handlers.js
5 @@ -57,7 +57,6 @@ function onLoad() { 5 @@ -57,7 +57,6 @@ function onLoad() {
6 fn: remoting.sendCtrlAltDel }, 6 fn: remoting.sendCtrlAltDel },
7 { event: 'click', id: 'send-print-screen', 7 { event: 'click', id: 'send-print-screen',
8 fn: remoting.sendPrintScreen }, 8 fn: remoting.sendPrintScreen },
9 - { event: 'click', id: 'auth-button', fn: doAuthRedirect }, 9 - { event: 'click', id: 'auth-button', fn: doAuthRedirect },
10 { event: 'click', id: 'share-button', fn: remoting.tryShare }, 10 { event: 'click', id: 'share-button', fn: remoting.tryShare },
11 { event: 'click', id: 'access-mode-button', fn: goEnterAccessCode }, 11 { event: 'click', id: 'access-mode-button', fn: goEnterAccessCode },
12 { event: 'click', id: 'cancel-share-button', fn: remoting.cancelShare }, 12 { event: 'click', id: 'cancel-share-button', fn: remoting.cancelShare },
13 @@ -118,6 +117,4 @@ function onBeforeUnload() { 13 @@ -117,6 +116,4 @@ function onBeforeUnload() {
14 } 14 }
15 15
16 window.addEventListener('load', onLoad, false); 16 window.addEventListener('load', onLoad, false);
17 -window.addEventListener('beforeunload', onBeforeUnload, false); 17 -window.addEventListener('beforeunload', onBeforeUnload, false);
18 window.addEventListener('resize', remoting.onResize, false); 18 window.addEventListener('resize', remoting.onResize, false);
19 -window.addEventListener('unload', remoting.disconnect, false); 19 -window.addEventListener('unload', remoting.disconnect, false);
20 diff --git a/remoting/webapp/host_controller.js b/remoting/webapp/host_controlle r.js 20 diff --git a/remoting/webapp/host_controller.js b/remoting/webapp/host_controlle r.js
21 index 83c9844..98f63c3 100644 21 index 83c9844..98f63c3 100644
22 --- a/host_controller.js 22 --- a/host_controller.js
23 +++ b/host_controller.js 23 +++ b/host_controller.js
24 @@ -341,7 +341,7 @@ remoting.HostController.prototype.getLocalHostStateAndId = f unction(onDone) { 24 @@ -341,7 +341,7 @@ remoting.HostController.prototype.getLocalHostStateAndId = f unction(onDone) {
25 onDone(state, that.localHostId_); 25 onDone(state, that.localHostId_);
26 }; 26 };
27 try { 27 try {
28 - this.plugin_.getDaemonConfig(onConfig); 28 - this.plugin_.getDaemonConfig(onConfig);
29 + onConfig('{}'); 29 + onConfig('{}');
30 } catch (err) { 30 } catch (err) {
31 onDone(remoting.HostController.State.NOT_IMPLEMENTED, null); 31 onDone(remoting.HostController.State.NOT_IMPLEMENTED, null);
32 } 32 }
33 diff --git a/remoting/webapp/host_table_entry.js b/remoting/webapp/host_table_en try.js 33 diff --git a/remoting/webapp/host_table_entry.js b/remoting/webapp/host_table_en try.js
34 index 4eb09d9..6d2ce85 100644 34 index 4eb09d9..6d2ce85 100644
35 --- a/host_table_entry.js 35 --- a/host_table_entry.js
36 +++ b/host_table_entry.js 36 +++ b/host_table_entry.js
37 @@ -191,9 +191,7 @@ remoting.HostTableEntry.prototype.updateStatus = function(op t_forEdit) { 37 @@ -176,9 +176,7 @@ remoting.HostTableEntry.prototype.updateStatus = function(op t_forEdit) {
38 /** @type {string} */ 38 /** @type {string} */
39 var encodedHostId = encodeURIComponent(this.host.hostId) 39 var encodedHostId = encodeURIComponent(this.host.hostId)
40 this.onConnectReference_ = function() { 40 this.onConnectReference_ = function() {
41 - var hostUrl = chrome.extension.getURL('main.html') + 41 - var hostUrl = chrome.extension.getURL('main.html') +
42 - '?mode=me2me&hostId=' + encodedHostId; 42 - '?mode=me2me&hostId=' + encodedHostId;
43 - window.location.assign(hostUrl); 43 - window.location.assign(hostUrl);
44 + remoting.connectMe2Me(encodedHostId, true); 44 + remoting.connectMe2Me(encodedHostId, true);
45 }; 45 };
46 this.tableRow.addEventListener('click', this.onConnectReference_, false); 46 this.tableRow.addEventListener('click', this.onConnectReference_, false);
47 } 47 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 - "matches": [ 82 - "matches": [
83 - "OAUTH2_REDIRECT_URL" 83 - "OAUTH2_REDIRECT_URL"
84 - ], 84 - ],
85 - "js": [ "cs_oauth2_trampoline.js" ] 85 - "js": [ "cs_oauth2_trampoline.js" ]
86 - } 86 - }
87 - ], 87 - ],
88 - "content_security_policy": "default-src 'self'; script-src 'self' TALK_GADGET _HOST; style-src 'self' https://fonts.googleapis.com; img-src 'self' TALK_GADGET _HOST; font-src *; connect-src 'self' OAUTH2_ACCOUNTS_HOST GOOGLE_API_HOSTS TALK _GADGET_HOST https://relay.google.com", 88 - "content_security_policy": "default-src 'self'; script-src 'self' TALK_GADGET _HOST; style-src 'self' https://fonts.googleapis.com; img-src 'self' TALK_GADGET _HOST; font-src *; connect-src 'self' OAUTH2_ACCOUNTS_HOST GOOGLE_API_HOSTS TALK _GADGET_HOST https://relay.google.com",
89 "permissions": [ 89 "permissions": [
90 "OAUTH2_ACCOUNTS_HOST/*", 90 "OAUTH2_ACCOUNTS_HOST/*",
91 "OAUTH2_API_BASE_URL/*", 91 "OAUTH2_API_BASE_URL/*",
92 @@ -30,17 +22,22 @@ 92 @@ -30,18 +22,22 @@
93 "TALK_GADGET_HOST/talkgadget/*", 93 "TALK_GADGET_HOST/talkgadget/*",
94 "https://relay.google.com/*", 94 "https://relay.google.com/*",
95 "storage",
95 "clipboardRead", 96 "clipboardRead",
96 - "clipboardWrite" 97 - "clipboardWrite"
97 - ], 98 - ],
98 - "plugins": [ 99 - "plugins": [
99 - { "path": "remoting_host_plugin.dll", "public": false }, 100 - { "path": "remoting_host_plugin.dll", "public": false },
100 - { "path": "libremoting_host_plugin.ia32.so", "public": false }, 101 - { "path": "libremoting_host_plugin.ia32.so", "public": false },
101 - { "path": "libremoting_host_plugin.x64.so", "public": false }, 102 - { "path": "libremoting_host_plugin.x64.so", "public": false },
102 - { "path": "remoting_host_plugin.plugin", "public": false } 103 - { "path": "remoting_host_plugin.plugin", "public": false }
103 + "clipboardWrite", 104 + "clipboardWrite",
104 + "experimental", 105 + "experimental"
105 + "storage"
106 ], 106 ],
107 + "oauth2": { 107 + "oauth2": {
108 + "client_id": "45833509441.apps.googleusercontent.com", 108 + "client_id": "45833509441.apps.googleusercontent.com",
109 + "scopes": [ 109 + "scopes": [
110 + "https://www.googleapis.com/auth/chromoting https://www.googleapis.com/au th/googletalk https://www.googleapis.com/auth/userinfo#email" 110 + "https://www.googleapis.com/auth/chromoting https://www.googleapis.com/au th/googletalk https://www.googleapis.com/auth/userinfo#email"
111 + ] 111 + ]
112 + }, 112 + },
113 "requirements": { 113 "requirements": {
114 "plugins": { 114 "plugins": {
115 "npapi": false 115 "npapi": false
(...skipping 12 matching lines...) Expand all
128 remoting.settings = new remoting.Settings(); 128 remoting.settings = new remoting.Settings();
129 remoting.oauth2 = new remoting.OAuth2(); 129 remoting.oauth2 = new remoting.OAuth2();
130 - // TODO(jamiewalch): Reinstate this when we migrate to apps v2 130 - // TODO(jamiewalch): Reinstate this when we migrate to apps v2
131 - // (http://crbug.com/ 134213). 131 - // (http://crbug.com/ 134213).
132 - // remoting.identity = new remoting.Identity(consentRequired_); 132 - // remoting.identity = new remoting.Identity(consentRequired_);
133 - remoting.identity = remoting.oauth2; 133 - remoting.identity = remoting.oauth2;
134 + remoting.identity = new remoting.Identity(consentRequired_); 134 + remoting.identity = new remoting.Identity(consentRequired_);
135 remoting.stats = new remoting.ConnectionStats( 135 remoting.stats = new remoting.ConnectionStats(
136 document.getElementById('statistics')); 136 document.getElementById('statistics'));
137 remoting.formatIq = new remoting.FormatIq(); 137 remoting.formatIq = new remoting.FormatIq();
138 @@ -118,9 +115,6 @@ remoting.initDaemonUi = function () { 138 @@ -129,9 +126,6 @@ remoting.initHomeScreenUi = function () {
139 document.getElementById('share-button').disabled = 139 document.getElementById('share-button').disabled =
140 !remoting.hostController.isPluginSupported(); 140 !remoting.hostController.isPluginSupported();
141 remoting.setMode(remoting.AppMode.HOME); 141 remoting.setMode(remoting.AppMode.HOME);
142 - if (!remoting.oauth2.isAuthenticated()) { 142 - if (!remoting.oauth2.isAuthenticated()) {
143 - document.getElementById('auth-dialog').hidden = false; 143 - document.getElementById('auth-dialog').hidden = false;
144 - } 144 - }
145 remoting.hostSetupDialog = 145 remoting.hostSetupDialog =
146 new remoting.HostSetupDialog(remoting.hostController); 146 new remoting.HostSetupDialog(remoting.hostController);
147 // Display the cached host list, then asynchronously update and re-display it . 147 // Display the cached host list, then asynchronously update and re-display it .
148 diff --git a/remoting/webapp/xhr_proxy.js b/remoting/webapp/xhr_proxy.js 148 diff --git a/remoting/webapp/xhr_proxy.js b/remoting/webapp/xhr_proxy.js
149 index 4c45780..653b481 100644 149 index 4c45780..653b481 100644
150 --- a/xhr_proxy.js 150 --- a/xhr_proxy.js
151 +++ b/xhr_proxy.js 151 +++ b/xhr_proxy.js
152 @@ -90,4 +90,4 @@ remoting.XMLHttpRequestProxy.prototype.DONE = 4; 152 @@ -90,4 +90,4 @@ remoting.XMLHttpRequestProxy.prototype.DONE = 4;
153 153
154 // Since the WCS driver code constructs XHRs directly, the only mechanism for 154 // Since the WCS driver code constructs XHRs directly, the only mechanism for
155 // proxying them is to replace the XMLHttpRequest constructor. 155 // proxying them is to replace the XMLHttpRequest constructor.
156 -//XMLHttpRequest = remoting.XMLHttpRequestProxy; 156 -//XMLHttpRequest = remoting.XMLHttpRequestProxy;
157 +XMLHttpRequest = remoting.XMLHttpRequestProxy; 157 +XMLHttpRequest = remoting.XMLHttpRequestProxy;
OLDNEW
« no previous file with comments | « remoting/webapp/all_js_load.gtestjs ('k') | remoting/webapp/jscompiler_hacks.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698